-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KUBESAW-16: Label the token secrets #396
KUBESAW-16: Label the token secrets #396
Conversation
clusters is labeled as belonging to its ToolchainCluster resource. This will be used in the future to base the creation of the ToolchainClusters on the existence of such secrets.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #396 +/- ##
==========================================
- Coverage 78.06% 77.87% -0.20%
==========================================
Files 47 47
Lines 1965 1984 +19
==========================================
+ Hits 1534 1545 +11
- Misses 373 378 +5
- Partials 58 61 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but let's also cover the error case when the update would fail.
Are you going to create also a e2e test for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice Job 👍
one minor question - should we add a test case for "secret not found" ?
to the reconciler when trying to label the secrets in the migration step.
good point 👍🏼 it's added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for addressing my comments!
Quality Gate passedIssues Measures |
Make sure the secret containing the creds for clients connecting between clusters is labeled as belonging to its ToolchainCluster resource.
This will be used in the future to base the creation of the ToolchainClusters on the existence of such secrets.
Associated PRs: