KUBESAW-16: Update the go.mod to use toolchaincluster controller from the toolchain-common KUBESAW-16 #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from the toolchain-common.
metlos
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
This was referenced May 10, 2024
# Conflicts: # go.mod # go.sum
metlos
changed the title
# Conflicts: # go.sum
mfrancisc
approved these changes
May 14, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: metlos, mfrancisc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1030 +/- ##
=======================================
Coverage 84.68% 84.68%
=======================================
Files 55 55
Lines 4877 4877
=======================================
Hits 4130 4130
Misses 574 574
Partials 173 173 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorporates the changes from codeready-toolchain/toolchain-common#396 and codeready-toolchain/api#423 into the host operator so that we can test the behavior by the updated e2e tests in codeready-toolchain/toolchain-e2e#970.
Associated PRs: