-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop all arbitrary SSO claim properties and annotations #393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please update the description with the links to the other PRs you created as well - for easy navigation?
Also, since you are removing quite a lot of things, could you please update also:
- registration-service
- sandbox-sre
repos with the api dependency?
@MatousJobanek thanks for the review. I do have branches for both registration service and sandbox-sre, but haven't raised PRs for them yet. My concern (mainly for registration service) is that we will have multiple branches with the same name which the e2e tests don't support. |
@sbryzak so why you just don't create PRs from different branches - using different names? |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Description
Removed SSO claim properties and annotations from everywhere except the formal IdentityClaims / PropagatedClaims types.
Fixes https://issues.redhat.com/browse/SANDBOX-504
Checks
Did you run
make generate
target? yesDid
make generate
change anything in other projects (host-operator, member-operator)? yesIn case of new CRD, did you the following? yes/no
resources/setup/roles/host.yaml
in the sandbox-sre repositoryPROJECT
file: https://github.com/codeready-toolchain/host-operator/blob/master/PROJECTCSV
file: https://github.com/codeready-toolchain/host-operator/blob/master/config/manifests/bases/host-operator.clusterserviceversion.yamlIn case other projects are changed, please provides PR links.