Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop all arbitrary SSO claim properties and annotations #393

Merged
merged 9 commits into from
Feb 7, 2024

Conversation

sbryzak
Copy link
Contributor

@sbryzak sbryzak commented Dec 29, 2023

Description

Removed SSO claim properties and annotations from everywhere except the formal IdentityClaims / PropagatedClaims types.

Fixes https://issues.redhat.com/browse/SANDBOX-504

Checks

  1. Did you run make generate target? yes

  2. Did make generate change anything in other projects (host-operator, member-operator)? yes

  3. In case of new CRD, did you the following? yes/no

  4. In case other projects are changed, please provides PR links.

Copy link
Contributor

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please update the description with the links to the other PRs you created as well - for easy navigation?
Also, since you are removing quite a lot of things, could you please update also:

  • registration-service
  • sandbox-sre

repos with the api dependency?

api/v1alpha1/annotations.go Outdated Show resolved Hide resolved
api/v1alpha1/annotations.go Outdated Show resolved Hide resolved
@sbryzak
Copy link
Contributor Author

sbryzak commented Jan 6, 2024

@MatousJobanek thanks for the review. I do have branches for both registration service and sandbox-sre, but haven't raised PRs for them yet. My concern (mainly for registration service) is that we will have multiple branches with the same name which the e2e tests don't support.

@MatousJobanek
Copy link
Contributor

@sbryzak so why you just don't create PRs from different branches - using different names?

Copy link

sonarqubecloud bot commented Feb 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sbryzak sbryzak merged commit 661b630 into codeready-toolchain:master Feb 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants