Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated API to remove all arbitrary SSO claim properties #872

Closed
wants to merge 5 commits into from

Conversation

sbryzak
Copy link
Contributor

@sbryzak sbryzak commented Dec 31, 2023

Related PRs:

codeready-toolchain/api#393
codeready-toolchain/host-operator#951

(Yes, there is also a member-operator PR with the same branch name. This will be addressed before this set of PRs is ready for merge).

Copy link

openshift-ci bot commented Dec 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbryzak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MatousJobanek
Copy link
Collaborator

(Yes, there is also a member-operator PR with the same branch name. This will be addressed before this set of PRs is ready for merge).

I'm sorry, but this cannot be ready for merge in the current state. We have the limitation when we can pair toolchain-e2e PR with only one PR for a good reason. This means, the e2e tests won't be executed for this PR at all which means it won't meet all required checks to be ready for merge.

In other words, this change needs to be properly propagated in each operator in an isolated manner.

Copy link

sonarqubecloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
9.4% Duplication on New Code

See analysis details on SonarCloud

Copy link

openshift-ci bot commented Jan 8, 2024

@sbryzak: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e a089043 link true /test e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbryzak sbryzak closed this Jan 11, 2024
@sbryzak sbryzak deleted the SANDBOX-504 branch January 11, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants