Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HomeSpace status field #384

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Add HomeSpace status field #384

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
080f063
Add HomeSpace status field
baijum Oct 18, 2023
ab5bad2
Use better description
baijum Oct 18, 2023
bf58427
Update geneated docs
baijum Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions api/v1alpha1/usersignup_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,11 @@ type UserSignupStatus struct {
// CompliantUsername is used to store the transformed, DNS-1123 compliant username
// +optional
CompliantUsername string `json:"compliantUsername,omitempty"`

// HomeSpace represents the default home space for the user.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor thing - maybe we could specify that this field will contain the name of the Space that is created for the user immediately after their account is approved. WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review!
Done. ab5bad2

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

It seems like the the generated.openapi.go file still has the old description for some reason : https://github.com/codeready-toolchain/api/pull/384/files#diff-72ca28827e299dac63194a397a04873f7f4d9fe3a216136c97a81c5e561d92acR4931

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. I missed copying that from the generated location. I had to copy it like this:
cp github.com/codeready-toolchain/api/api/v1alpha1/zz_generated.openapi.go api/v1alpha1/

Fixed here: bf58427

Copy link
Contributor

@mfrancisc mfrancisc Oct 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can avoid the copy if you clone the projects into your GOPATH location for example:
GOPATH="~/go"
and projects should be located at:
~/go/src/github.com/codeready-toolchain/api
same location for the other toolchain projects.

// This is used by the proxy when no workspace context is provided.
// +optional
HomeSpace string `json:"homeSpace,omitempty"`
}

//+kubebuilder:object:root=true
Expand Down
7 changes: 7 additions & 0 deletions api/v1alpha1/zz_generated.openapi.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.