Add HomeSpace status field #384
Conversation
This field is going to be used by the proxy when no workspace context is provided. Signed-off-by: Baiju Muthukadan <[email protected]>
baijum
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
api/v1alpha1/usersignup_types.go
Outdated
| @@ -265,6 +265,11 @@ type UserSignupStatus struct { | |||
| // CompliantUsername is used to store the transformed, DNS-1123 compliant username | |||
| // +optional | |||
| CompliantUsername string `json:"compliantUsername,omitempty"` | |||
|
|
|||
| // HomeSpace represents the default home space for the user. | |||
There was a problem hiding this comment.
minor thing - maybe we could specify that this field will contain the name of the Space that is created for the user immediately after their account is approved. WDYT?
There was a problem hiding this comment.
Thanks for the review!
Done. ab5bad2
There was a problem hiding this comment.
Thanks!
It seems like the the generated.openapi.go file still has the old description for some reason : https://github.com/codeready-toolchain/api/pull/384/files#diff-72ca28827e299dac63194a397a04873f7f4d9fe3a216136c97a81c5e561d92acR4931
There was a problem hiding this comment.
Ah. I missed copying that from the generated location. I had to copy it like this:
cp github.com/codeready-toolchain/api/api/v1alpha1/zz_generated.openapi.go api/v1alpha1/
Fixed here: bf58427
There was a problem hiding this comment.
you can avoid the copy if you clone the projects into your GOPATH location for example:
GOPATH="~/go"
and projects should be located at:
~/go/src/github.com/codeready-toolchain/api
same location for the other toolchain projects.
Signed-off-by: Baiju Muthukadan <[email protected]>
Signed-off-by: Baiju Muthukadan <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Description
This field is going to be used by the proxy when no workspace context is provided.
Ref. Ref. https://issues.redhat.com/browse/SANDBOX-425
Checks
Did you run
make generatetarget? yesDid
make generatechange anything in other projects (host-operator, member-operator)? yesIn case of new CRD, did you the following? no
resources/setup/roles/host.yamlin the sandbox-sre repositoryPROJECTfile: https://github.com/codeready-toolchain/host-operator/blob/master/PROJECTCSVfile: https://github.com/codeready-toolchain/host-operator/blob/master/config/manifests/bases/host-operator.clusterserviceversion.yamlIn case other projects are changed, please provides PR links.