Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASC-402: Modify NSTemplateTierSpec to support SA token copy #380

Merged
merged 11 commits into from
Oct 17, 2023
Binary file removed .DS_Store
Binary file not shown.
12 changes: 12 additions & 0 deletions api/v1alpha1/nstemplatetier_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,18 @@ type NSTemplateTierSpec struct {
// +optional
// +mapType=atomic
SpaceRoles map[string]NSTemplateTierSpaceRole `json:"spaceRoles,omitempty"`

// SpaceRequestConfig stores all the configuration related to the Space Request feature
// +optional
SpaceRequestConfig *SpaceRequestConfig `json:"spaceRequestConfig,omitempty"`
}

// SpaceRequestConfig contains all the configuration related to the Space Request feature
// +k8s:openapi-gen=true
type SpaceRequestConfig struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type SpaceRequestConfig struct {
// +k8s:openapi-gen=true
type SpaceRequestConfig struct {

// Provides the name of the Service Account whose token is to be copied
// +optional
ServiceAccountName string `json:"serviceAccountName,omitempty"`
}

// NSTemplateTierNamespace the namespace definition in an NSTemplateTier resource
Expand Down
20 changes: 20 additions & 0 deletions api/v1alpha1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

29 changes: 28 additions & 1 deletion api/v1alpha1/zz_generated.openapi.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.