ASC-402: Modify NSTemplateTierSpec to support SA token copy #380
Conversation
Signed-off-by: Kartikey Mamgain <[email protected]>
Signed-off-by: Kartikey Mamgain <[email protected]>
api/v1alpha1/nstemplatetier_types.go
Outdated
|
|
||
| // flag to signify whether to copy SA token or not | ||
| // +optional | ||
| CopySaToken bool `json:"copySaToken,omitempty"` |
There was a problem hiding this comment.
This is a SpaceRequest specific configuration (it's used only when the Space is created based on SpaceRequest CR), not a generic one. I would structure it so it's easy to understand - something like this:
// +optional
SpaceRequestConfig SpaceRequestConfig `json:"spaceRequestConfig, omitempty"`
}
type SpaceRequestConfig struct {
// +optional
CopySaToken bool `json:"copySaToken,omitempty"`
}if needed, we could easily extend the part by other values in the future, for example:
type SpaceRequestConfig struct {
// +optional
CopySaToken bool `json:"copySaToken,omitempty"`
// +optional
ManagerSaName string `json:"managerSaName,omitempty"`
}another approach would be:
type SpaceRequestConfig struct {
// +optional
SaTokenToCopy string `json:"saTokenToCopy,omitempty"`
}if nothing is provided, then the controller wouldn't copy anything, otherwise, it would contain the name of the SA whose token should be copied - ie. namespace-manager
WDYT?
There was a problem hiding this comment.
Let's go with the last one . Looks better.
type SpaceRequestConfig struct {
// +optional
SaTokenToCopy string json:"saTokenToCopy,omitempty"
}
|
@Kartikey-star yes, it's recommended to clone all the projects into this folder structure in order for the same for the other repos host-operator|registration-service|member-operator|toolchain-e2e .... |
Signed-off-by: Kartikey Mamgain <[email protected]>
|
Thanks @mfrancisc , I had cloned the repos outside my GOPATH..Fixing that seems to work. |
| SpaceRequestConfigName SpaceRequestConfig `json:"spaceRequestConfig,omitempty"` | ||
| } | ||
|
|
||
| type SpaceRequestConfig struct { |
There was a problem hiding this comment.
| type SpaceRequestConfig struct { | |
| // +k8s:openapi-gen=true | |
| type SpaceRequestConfig struct { |
Signed-off-by: Kartikey Mamgain <[email protected]>
Signed-off-by: Kartikey Mamgain <[email protected]>
Kartikey-star
requested review from
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19 and
sbryzak
as code owners
api/v1alpha1/nstemplatetier_types.go
Outdated
| @@ -22,6 +22,17 @@ type NSTemplateTierSpec struct { | |||
| // +optional | |||
| // +mapType=atomic | |||
| SpaceRoles map[string]NSTemplateTierSpaceRole `json:"spaceRoles,omitempty"` | |||
|
|
|||
| // Provides the name of the Service Account whose token is to be copied | |||
There was a problem hiding this comment.
minor thing - but I guess this comment relates more to the SaTokenToCopy field, while the struct comment could be something generic like: "SpaceRequestConfigName stores all the configuration related to the Space Request feature".
WDYT?
There was a problem hiding this comment.
same for the comment on the struct at line 31.
There was a problem hiding this comment.
That seems better to me .Updated .
Signed-off-by: Kartikey Mamgain <[email protected]>
Signed-off-by: Kartikey Mamgain <[email protected]>
api/v1alpha1/nstemplatetier_types.go
Outdated
| // SpaceRequestConfigName stores all the configuration related to the Space Request feature | ||
| // +optional | ||
| SpaceRequestConfigName *SpaceRequestConfig `json:"spaceRequestConfig,omitempty"` |
There was a problem hiding this comment.
Why is there the "Name" suffix?
It should be
| // SpaceRequestConfigName stores all the configuration related to the Space Request feature | |
| // +optional | |
| SpaceRequestConfigName *SpaceRequestConfig `json:"spaceRequestConfig,omitempty"` | |
| // SpaceRequestConfig stores all the configuration related to the Space Request feature | |
| // +optional | |
| SpaceRequestConfig *SpaceRequestConfig `json:"spaceRequestConfig,omitempty"` |
This file does exists on the main branch itself https://github.com/codeready-toolchain/api, it got altered hence committed. Shall i delete it? |
Signed-off-by: Kartikey Mamgain <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Description
A few sentences describing the overall goals of the pull request's commits.
Checks
Did you run
make generatetarget? YesDid
make generatechange anything in other projects (host-operator, member-operator)? YesIn case of new CRD, did you the following? yes/no
resources/setup/roles/host.yamlin the sandbox-sre repositoryPROJECTfile: https://github.com/codeready-toolchain/host-operator/blob/master/PROJECTCSVfile: https://github.com/codeready-toolchain/host-operator/blob/master/config/manifests/bases/host-operator.clusterserviceversion.yamlIn case other projects are changed, please provides PR links.