Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload error reporting #1086

Closed
Tracked by #1450
codecovdesign opened this issue Jan 24, 2024 · 7 comments
Closed
Tracked by #1450

Upload error reporting #1086

codecovdesign opened this issue Jan 24, 2024 · 7 comments
Assignees
Labels
bug Something isn't working Dev-Ready This means the UX is reviewed and ready for prioritization scheduling. Polish polish, tweaks, and bug issues that are small iterations and/or not part of larger quarterly epics

Comments

@codecovdesign
Copy link
Contributor

codecovdesign commented Jan 24, 2024

Problem to solve

Description

In the scenario of failed uploads, we show in the aside, summary and empty state. The copy isn't as clear as it's a fragmented in the sections and the summary message is generic in that scenario.

Steps to Reproduce / Current UX

Screenshot 2024-01-24 at 08 45 23

Solution (Latest)

The ask here is to make the error messagings clear and actionable.
In total, we have 5 upload errors and 4 to update. (no change for "Unknown error")

  1. Processing failed --> Upload failed. Please rerun the upload.
  2. Upload expired --> Upload exceeds the max. age of 12h. Please download and review your report or turn off the age check by visiting expired reports.
  3. Unusable report --> Unusable report due to issues such as source code unavailability, path mismatch, empty report, or incorrect data format. Please visit our troubleshooting document for assistance.
  4. Multiple flags --> Multiple flags detected. Please ensure one flag per upload.

See design for these error messagings:
Screenshot 2024-04-16 at 11 47 50 AM
Figma: link

Additional Information

@codecovdesign codecovdesign added in discovery The design, product, and specifications require refinement Polish polish, tweaks, and bug issues that are small iterations and/or not part of larger quarterly epics labels Jan 24, 2024
@codecovdesign codecovdesign changed the title <Enter Title for Problem and/or Improvement> Upload error reporting Jan 24, 2024
@Adal3n3
Copy link

Adal3n3 commented Mar 29, 2024

Screenshot 2024-03-29 at 4 16 33 PM

@nicholas-codecov On the upload status, what are the differences between "Processing failed" and "Unknown error"? Can you point me to the list of error scenarios, like upload incomplete, incorrect file format, etc.

@nicholas-codecov
Copy link

I'm not really sure of what the difference is on a technical level, this is just what we get back from the API and display it. Maybe @giovanni-guidini or @joseph-sentry can answer

@Adal3n3
Copy link

Adal3n3 commented Apr 8, 2024

According to the Error reporting, we have 4 errors conditions

https://github.com/codecov/gazebo/blob/7c3919c56bf8cce36f90b3b3bdc94371ced6a7be/sr[…]ges/CommitDetailPage/CommitCoverage/UploadsCard/RenderError.jsx

const UploadErrorMessage = Object.freeze({
[ErrorCodeEnum.fileNotFoundInStorage]: 'processing failed',
[ErrorCodeEnum.reportExpired]: 'upload expired',
[ErrorCodeEnum.reportEmpty]: 'unusable report',
noMatch: 'unknown error',
})

  1. Processing failed
  • The upload not found in storage
  • If upload not found in storage will not have the download link.

  1. Upload expired
  • Codecov will reject reports that are over 12 hours old according to the timestamp in the report. This is to prevent reports that may have been accidentally checked into git.
  1. Unusable report
  1. Unknown error
    -According to Matt, it is genuinely unknown. Slack thread: https://sentry.slack.com/archives/C04NC9NNPEG/p1712350674153459

    -future work: make upload error reporting more consistent #1520

@Adal3n3
Copy link

Adal3n3 commented Apr 8, 2024

Figma: link
The improvement here is to help developers understand their errors and provide an actionable next step for them to fix their errors. Here's the proposed error messages that covered above 4 errors:

Screenshot 2024-04-08 at 3 29 53 PM

@Adal3n3
Copy link

Adal3n3 commented Apr 8, 2024

@drazisil-codecov
Copy link

I like option 2 in both cases, and see no problems with the other message changes. 👍

@Adal3n3 Adal3n3 added Dev-Ready This means the UX is reviewed and ready for prioritization scheduling. and removed in discovery The design, product, and specifications require refinement labels Apr 10, 2024
@Adal3n3
Copy link

Adal3n3 commented Apr 16, 2024

@katia-sentry can you prioritize this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Dev-Ready This means the UX is reviewed and ready for prioritization scheduling. Polish polish, tweaks, and bug issues that are small iterations and/or not part of larger quarterly epics
Projects
None yet
Development

No branches or pull requests

5 participants