Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show pro tip in cases for multiple flags with one upload #201

Closed
Tracked by #199 ...
codecovdesign opened this issue Jul 17, 2023 · 4 comments · Fixed by codecov/gazebo#3375
Closed
Tracked by #199 ...

Show pro tip in cases for multiple flags with one upload #201

codecovdesign opened this issue Jul 17, 2023 · 4 comments · Fixed by codecov/gazebo#3375
Assignees
Labels
Dev-Ready This means the UX is reviewed and ready for prioritization scheduling. Polish polish, tweaks, and bug issues that are small iterations and/or not part of larger quarterly epics

Comments

@codecovdesign
Copy link
Contributor

codecovdesign commented Jul 17, 2023

Problem to solve

Proper configuration should result in 1 flag per upload. Sometimes, misconfiguration leads to multiple flags in the upload aside.

Solution

Display some visual treatment in the form of “pro-tip“ or in app troubleshooting to helps user understand this discrepancy.

The ask here is to show it as an error message and provide solution for the fix.
Screenshot 2024-04-16 at 1 01 11 PM

Figma designs [This is not the latest design]

Figma: link

@trent-codecov trent-codecov transferred this issue from another repository Aug 3, 2023
@trent-codecov trent-codecov transferred this issue from codecov/engineering-team Aug 3, 2023
@trent-codecov trent-codecov transferred this issue from another repository Aug 9, 2023
@codecovdesign codecovdesign added in discovery The design, product, and specifications require refinement Polish polish, tweaks, and bug issues that are small iterations and/or not part of larger quarterly epics labels Dec 28, 2023
@Adal3n3
Copy link

Adal3n3 commented Apr 9, 2024

@codecovdesign The upload error reporting issue #1086 has covered this flag error. We can decouple the error messages here as well.

#1086 (comment)

@Adal3n3
Copy link

Adal3n3 commented Apr 9, 2024

Figma: link

The ask here is just update the flag error message.

Screenshot 2024-04-09 at 11 48 56 AM

@Adal3n3 Adal3n3 self-assigned this Apr 9, 2024
@Adal3n3 Adal3n3 added Dev-Ready This means the UX is reviewed and ready for prioritization scheduling. and removed in discovery The design, product, and specifications require refinement labels Apr 10, 2024
@Adal3n3
Copy link

Adal3n3 commented Apr 16, 2024

@katia-sentry Can you prioritize this? You will see this "Multiple flags" error on the Upload error reporting issue which they are the same #1086 If you prefer to decouple the fixes we can keep this issue or close this issue as it'll be covered from issue 1086. What do you think?

@Adal3n3
Copy link

Adal3n3 commented Sep 11, 2024

If we can't do #2498 this is 1 day eng work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev-Ready This means the UX is reviewed and ready for prioritization scheduling. Polish polish, tweaks, and bug issues that are small iterations and/or not part of larger quarterly epics
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants