Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Refactor current upload error messaging #2998

Merged
merged 3 commits into from
Jul 15, 2024
Merged

ref: Refactor current upload error messaging #2998

merged 3 commits into from
Jul 15, 2024

Conversation

RulaKhaled
Copy link
Contributor

Description

According to codecov/engineering-team#1086 we're looking to improve messages of different upload errors

Notable Changes

  • different copies for render error
  • tests

Screenshots

Screenshot 2024-07-10 at 3 30 34 PM

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-qa
Copy link

codecov-qa bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (e1d27eb) to head (57fcb03).
Report is 15 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2998      +/-   ##
==========================================
+ Coverage   98.33%   98.35%   +0.01%     
==========================================
  Files         902      907       +5     
  Lines       13318    13474     +156     
  Branches     3553     3605      +52     
==========================================
+ Hits        13096    13252     +156     
  Misses        218      218              
  Partials        4        4              
Files Coverage Δ
...ailPage/CommitCoverage/UploadsCard/RenderError.tsx 100.00% <100.00%> (ø)
...rvices/navigation/useNavLinks/useStaticNavLinks.js 97.18% <100.00%> (+0.08%) ⬆️

... and 35 files with indirect coverage changes

Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.52% <ø> (+0.04%) ⬆️
Pages 99.15% <100.00%> (+<0.01%) ⬆️
Services 99.47% <100.00%> (+<0.01%) ⬆️
Shared 99.69% <ø> (+<0.01%) ⬆️
UI 94.27% <ø> (+0.08%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1d27eb...57fcb03. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2998      +/-   ##
==========================================
+ Coverage   98.33%   98.35%   +0.01%     
==========================================
  Files         902      907       +5     
  Lines       13318    13474     +156     
  Branches     3533     3605      +72     
==========================================
+ Hits        13096    13252     +156     
  Misses        218      218              
  Partials        4        4              
Files Coverage Δ
...ailPage/CommitCoverage/UploadsCard/RenderError.tsx 100.00% <100.00%> (ø)
...rvices/navigation/useNavLinks/useStaticNavLinks.js 97.18% <100.00%> (+0.08%) ⬆️

... and 35 files with indirect coverage changes

Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.52% <ø> (+0.04%) ⬆️
Pages 99.15% <100.00%> (+<0.01%) ⬆️
Services 99.47% <100.00%> (+<0.01%) ⬆️
Shared 99.69% <ø> (+<0.01%) ⬆️
UI 94.27% <ø> (+0.08%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1d27eb...57fcb03. Read the comment docs.

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (e1d27eb) to head (57fcb03).
Report is 15 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##               main      #2998        +/-   ##
================================================
+ Coverage   98.33000   98.35000   +0.02000     
================================================
  Files           902        907         +5     
  Lines         13318      13474       +156     
  Branches       3553       3605        +52     
================================================
+ Hits          13096      13252       +156     
  Misses          218        218                
  Partials          4          4                
Files Coverage Δ
...ailPage/CommitCoverage/UploadsCard/RenderError.tsx 100.00% <100.00%> (ø)
...rvices/navigation/useNavLinks/useStaticNavLinks.js 97.18% <100.00%> (+0.08%) ⬆️

... and 35 files with indirect coverage changes

Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.52% <ø> (+0.04%) ⬆️
Pages 99.15% <100.00%> (+<0.01%) ⬆️
Services 99.47% <100.00%> (+<0.01%) ⬆️
Shared 99.69% <ø> (+<0.01%) ⬆️
UI 94.27% <ø> (+0.08%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1d27eb...57fcb03. Read the comment docs.

Copy link

codecov-public-qa bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (e1d27eb) to head (57fcb03).
Report is 15 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2998      +/-   ##
==========================================
+ Coverage   98.33%   98.35%   +0.01%     
==========================================
  Files         902      907       +5     
  Lines       13318    13474     +156     
  Branches     3558     3557       -1     
==========================================
+ Hits        13096    13252     +156     
  Misses        218      218              
  Partials        4        4              
Files Coverage Δ
...ailPage/CommitCoverage/UploadsCard/RenderError.tsx 100.00% <100.00%> (ø)
...rvices/navigation/useNavLinks/useStaticNavLinks.js 97.18% <100.00%> (+0.08%) ⬆️

... and 35 files with indirect coverage changes

Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.52% <ø> (+0.04%) ⬆️
Pages 99.15% <100.00%> (+<0.01%) ⬆️
Services 99.47% <100.00%> (+<0.01%) ⬆️
Shared 99.69% <ø> (+<0.01%) ⬆️
UI 94.27% <ø> (+0.08%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1d27eb...57fcb03. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Jul 10, 2024

Bundle Report

Changes will increase total bundle size by 13.68kB ⬆️

Bundle name Size Change
gazebo-staging-array-push 6.1MB 13.68kB ⬆️

Copy link

codecov bot commented Jul 10, 2024

Bundle Report

Changes will increase total bundle size by 13.68kB ⬆️

Bundle name Size Change
gazebo-production-array-push 6.1MB 13.68kB ⬆️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Jul 10, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
64a02cc Wed, 10 Jul 2024 14:05:27 GMT Expired Expired
a30b1d8 Mon, 15 Jul 2024 09:22:09 GMT Expired Expired
57fcb03 Mon, 15 Jul 2024 09:34:57 GMT Cloud Enterprise

@RulaKhaled RulaKhaled marked this pull request as ready for review July 15, 2024 10:42
Copy link
Contributor

@spalmurray-codecov spalmurray-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@RulaKhaled RulaKhaled added this pull request to the merge queue Jul 15, 2024
Merged via the queue into main with commit 3e9e76f Jul 15, 2024
61 checks passed
@RulaKhaled RulaKhaled deleted the upload-err branch July 15, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants