-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: Refactor current upload error messaging #2998
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #2998 +/- ##
==========================================
+ Coverage 98.33% 98.35% +0.01%
==========================================
Files 902 907 +5
Lines 13318 13474 +156
Branches 3553 3605 +52
==========================================
+ Hits 13096 13252 +156
Misses 218 218
Partials 4 4
... and 35 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #2998 +/- ##
==========================================
+ Coverage 98.33% 98.35% +0.01%
==========================================
Files 902 907 +5
Lines 13318 13474 +156
Branches 3533 3605 +72
==========================================
+ Hits 13096 13252 +156
Misses 218 218
Partials 4 4
... and 35 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2998 +/- ##
================================================
+ Coverage 98.33000 98.35000 +0.02000
================================================
Files 902 907 +5
Lines 13318 13474 +156
Branches 3553 3605 +52
================================================
+ Hits 13096 13252 +156
Misses 218 218
Partials 4 4
... and 35 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #2998 +/- ##
==========================================
+ Coverage 98.33% 98.35% +0.01%
==========================================
Files 902 907 +5
Lines 13318 13474 +156
Branches 3558 3557 -1
==========================================
+ Hits 13096 13252 +156
Misses 218 218
Partials 4 4
... and 35 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 13.68kB ⬆️
|
Bundle ReportChanges will increase total bundle size by 13.68kB ⬆️
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Description
According to codecov/engineering-team#1086 we're looking to improve messages of different upload errors
Notable Changes
Screenshots
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.