sql: rerun execbuilder for gist matching #127604
Open
+73
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
yuzefovich
force-pushed
the
bundle-gist-v2
branch
2 times, most recently
from
b2fc238
to
ff865fe
Compare
This commit re-runs the execbuilder with the explain factory whenever plan-gist matching happens. This allows us to fully populate `plan.txt` contents of the bundle. Some care had to be taken to ensure that the new plan is used going forward (for correct annotation with exec stats). We also make a copy of the memo to be safe (so that the original memo isn't mutated by the execbuilder). Release note (bug fix): Previously, whenever CockroachDB collected a statement bundle when plan-gist-based matching was used, `plan.txt` file would be incomplete, and this is now fixed. The bug has been present since introduction of plan-gist-based matching feature in 23.1 but was partially addressed in 24.2 release.
yuzefovich
force-pushed
the
bundle-gist-v2
branch
from
ff865fe
to
5844e5d
Compare
yuzefovich
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit re-runs the execbuilder with the explain factory whenever plan-gist matching happens. This allows us to fully populate
plan.txtcontents of the bundle. Some care had to be taken to ensure that the new plan is used going forward (for correct annotation with exec stats). We also make a copy of the memo to be safe (so that the original memo isn't mutated by the execbuilder).Follow-up to #125465.
Epic: None
Release note (bug fix): Previously, whenever CockroachDB collected a statement bundle when plan-gist-based matching was used,
plan.txtfile would be incomplete, and this is now fixed. The bug has been present since introduction of plan-gist-based matching feature in 23.1 but was partially addressed in 24.2 release.