Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: rerun execbuilder for gist matching #127604

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sql: rerun execbuilder for gist matching #127604

wants to merge 1 commit into from

Commits on Nov 23, 2024

  1. sql: rerun execbuilder for gist matching 

    This commit re-runs the execbuilder with the explain factory whenever
plan-gist matching happens. This allows us to fully populate `plan.txt`
contents of the bundle. Some care had to be taken to ensure that the new
plan is used going forward (for correct annotation with exec stats). We
also make a copy of the memo to be safe (so that the original memo isn't
mutated by the execbuilder).

Release note (bug fix): Previously, whenever CockroachDB collected
a statement bundle when plan-gist-based matching was used, `plan.txt`
file would be incomplete, and this is now fixed. The bug has been
present since introduction of plan-gist-based matching feature in 23.1
but was partially addressed in 24.2 release.
    @yuzefovich
    yuzefovich committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    5844e5d View commit details
    Browse the repository at this point in the history