Skip to content
This repository has been archived by the owner on Feb 1, 2019. It is now read-only.

Adds tests; Stale #3

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .coafile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[Default]
files = *.py, coala_langserver/*.py, tests/**/*.py
files = *.py, coalals/**/*.py, tests/**/*.py

max_line_length = 79
use_spaces = True
Expand Down
2 changes: 1 addition & 1 deletion .codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ coverage:
project:
default:
enabled: true
target: 95%
target: 100%
2 changes: 1 addition & 1 deletion .coveragerc
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
branch = True
source = .
omit =
coala-langserver.py
coalals/__main__.py
tests/*

[report]
Expand Down
13 changes: 1 addition & 12 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,6 @@ before_install:
sleep 3;
fi

- cd ./vscode-client
- npm install
- mkdir ./out
- npm run vscode:prepublish
- cd - > /dev/null

- printf '%s\n'
"$(cat test-requirements.txt requirements.txt)"
> requirements.txt
Expand All @@ -41,12 +35,7 @@ script:
# https://github.com/coala/coala-bears/issues/1037
- sed -i.bak '/bears = GitCommitBear/d' .coafile
# Server side tests.
- coverage run $(which behave) ./tests/server.features
- coverage run -a -m unittest discover -s tests
# Frontend tests.
# - cd ./vscode-client
# - npm test
# - cd - > /dev/null
- py.test --cov-report term --cov=coalals
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we not using behave?

That hasnt been discussed anywhere publicly that I have seen.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests previously were fragmented between behave and unittest and the current changes required changes to most of those tests. So, the few reusable tests have been rewritten too in pytest and pytest now covers all the codebase.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a discussion privately. @ksdme and me thought that he is familiar with unittest which is heavily used in coala/coala. Thus we decided to unify the tool. Sorry that we do not open an issue to keep track of the change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the current changes required changes to most of those tests.

ok, I'll have a closer look at the current changes to better understand why.


notifications:
email: false
Expand Down
17 changes: 4 additions & 13 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,17 +1,11 @@
# coala-vs-code
# coala-ls

[![Build Status](https://travis-ci.org/coala/coala-vs-code.svg?branch=master)](https://travis-ci.org/coala/coala-vs-code)
[![codecov](https://codecov.io/gh/coala/coala-vs-code/branch/master/graph/badge.svg)](https://codecov.io/gh/coala/coala-vs-code)
A coala language server based on [Language Server Protocol (LSP)](https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md). Python versions 3.x is supported.

A visual studio code plugin working via [Language Server Protocol (LSP)](https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md).Python versions 3.x is supported.

## Feature preview

![](./docs/images/demo.gif)

## Setting up your dev environment, coding, and debugging

You'll need python version 3.5 or greater, run `pip3 install -r requirements.txt` to install the requirements, and run `python3 langserver-python.py --mode=tcp --addr=2087` to start a local languager server listening at port 2087.
You'll need python version 3.5 or greater, run `pip3 install -r requirements.txt` to install the requirements, and run `python3 -m coalals --mode=tcp --addr=2087` to start a local languager server listening at port 2087.

Then you should update the `./vscode-client/src/extension.ts` to make client in TCP mode.

Expand All @@ -26,10 +20,7 @@ export function activate(context: ExtensionContext) {

To try it in [Visual Studio Code](https://code.visualstudio.com), open ./vscode-client in VS Code and turn to debug view, launch the extension.

## Known bugs

* [Language server restarts when `didSave` requests come](https://github.com/coala/coala-vs-code/issues/7)

## Reference

* [python-langserver](https://github.com/sourcegraph/python-langserver)
* [python-language-server](http://github.com/palantir/python-language-server)
11 changes: 0 additions & 11 deletions coala-langserver.py

This file was deleted.

2 changes: 1 addition & 1 deletion coala-langserver.sh → coala-ls.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/sh

cd "$(dirname "$0")" > /dev/null
exec python3 ./coala-langserver.py
exec python3 -m coalals
cd - /dev/null
30 changes: 0 additions & 30 deletions coala_langserver/coalashim.py

This file was deleted.

56 changes: 0 additions & 56 deletions coala_langserver/diagnostic.py

This file was deleted.

156 changes: 0 additions & 156 deletions coala_langserver/langserver.py

This file was deleted.

6 changes: 0 additions & 6 deletions coala_langserver/log.py

This file was deleted.

18 changes: 0 additions & 18 deletions coala_langserver/uri.py

This file was deleted.

File renamed without changes.
9 changes: 9 additions & 0 deletions coalals/__main__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
from sys import argv, stdout
from .main import main
from .utils.log import configure_logger

import logging
configure_logger()

if __name__ == '__main__':
main()
Empty file added coalals/coaconfig/__init__.py
Empty file.
Loading