-
Notifications
You must be signed in to change notification settings - Fork 6
Adds tests; Stale #3
base: master
Are you sure you want to change the base?
Conversation
@jayvdb Please enable Codecov. |
.gitignore
Outdated
.vscode/ | ||
|
||
# pytest cache | ||
.pytest_cache/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
covered by #4
# - cd ./vscode-client | ||
# - npm test | ||
# - cd - > /dev/null | ||
- py.test --cov-report term --cov=coalals |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we not using behave
?
That hasnt been discussed anywhere publicly that I have seen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests previously were fragmented between behave and unittest and the current changes required changes to most of those tests. So, the few reusable tests have been rewritten too in pytest and pytest now covers all the codebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a discussion privately. @ksdme and me thought that he is familiar with unittest which is heavily used in coala/coala. Thus we decided to unify the tool. Sorry that we do not open an issue to keep track of the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the current changes required changes to most of those tests.
ok, I'll have a closer look at the current changes to better understand why.
Travis tests have failedHey @ksdme, 1st Buildpy.test --cov-report term --cov=coalals
|
a787b7f
to
f5a78ce
Compare
Hey @ksdme, TravisCI finished with status |
This updates the project with some fixes, improves the code style and adds generalization.
The code omission and coverage requirements are updated.
The existsing fragmented tests are dropped in favour of pytest tests.
The entire module now has a standard test suite in pytest with full coverage.
Travis tests have failedHey @ksdme, 3rd Buildpy.test --cov-report term --cov=coalals
|
This updates the test requirements and travis configuration.
Is the PR still WIP? |
I think we could close the issue since we decided to add corresponding test cases in #2 |
Yes, I have suggested than on gitter. |
@jayvdb Can I close this PR? |
No description provided.