generate_bear_requirements.py: Add Perl Metadata #2888

Ishaan29 · 2019-03-11T15:24:31Z

This enhances generate_bear_requirements.py to support
perl bears and generate Makefile.PL using jinja2
template.
closes #2483

gitmate-bot · 2019-03-11T15:26:48Z

bears/perl/PerlCriticBear.py

@@ -24,15 +28,18 @@ class PerlCriticBear:

    LANGUAGES = {'Perl'}
    REQUIREMENTS = {
-        DistributionRequirement(
+        AnyOneOfRequirements(
+        [   PerlRequirement(package='Critic',version='==1.126'),


The code does not comply to PEP8.

Origin: PEP8Bear, Section: all.autopep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp68ivg31q/bears/perl/PerlCriticBear.py +++ b/tmp/tmp68ivg31q/bears/perl/PerlCriticBear.py @@ -29,16 +29,16 @@ LANGUAGES = {'Perl'} REQUIREMENTS = { AnyOneOfRequirements( - [ PerlRequirement(package='Critic',version='==1.126'), - DistributionRequirement( - apt_get='libperl-critic-perl', - brew=None, - dnf='perl-Perl-Critic', - portage='dev-perl/Perl-Critic', - xbps=None, - yum='perl-Perl-Critic', - zypper='perl-Perl-Critic', - ),] + [PerlRequirement(package='Critic', version='==1.126'), + DistributionRequirement( + apt_get='libperl-critic-perl', + brew=None, + dnf='perl-Perl-Critic', + portage='dev-perl/Perl-Critic', + xbps=None, + yum='perl-Perl-Critic', + zypper='perl-Perl-Critic', + ), ] ) } AUTHORS = {'The coala developers'}

gitmate-bot · 2019-03-11T15:26:49Z

bears/perl/PerlCriticBear.py

@@ -24,15 +28,18 @@ class PerlCriticBear:

    LANGUAGES = {'Perl'}
    REQUIREMENTS = {
-        DistributionRequirement(
+        AnyOneOfRequirements(
+        [   PerlRequirement(package='Critic',version='==1.126'),


E122 continuation line missing indentation or outdented

Origin: PycodestyleBear (E122), Section: all.autopep8.

gitmate-bot · 2019-03-11T15:26:50Z

bears/perl/PerlCriticBear.py

@@ -24,15 +28,18 @@ class PerlCriticBear:

    LANGUAGES = {'Perl'}
    REQUIREMENTS = {
-        DistributionRequirement(
+        AnyOneOfRequirements(
+        [   PerlRequirement(package='Critic',version='==1.126'),


E201 whitespace after '['

Origin: PycodestyleBear (E201), Section: all.autopep8.

gitmate-bot · 2019-03-11T15:26:52Z

bears/perl/PerlCriticBear.py

@@ -24,15 +28,18 @@ class PerlCriticBear:

    LANGUAGES = {'Perl'}
    REQUIREMENTS = {
-        DistributionRequirement(
+        AnyOneOfRequirements(
+        [   PerlRequirement(package='Critic',version='==1.126'),


E231 missing whitespace after ','

Origin: PycodestyleBear (E231), Section: all.autopep8.

gitmate-bot · 2019-03-11T15:26:53Z

bears/perl/PerlCriticBear.py

            apt_get='libperl-critic-perl',
            brew=None,
            dnf='perl-Perl-Critic',
            portage='dev-perl/Perl-Critic',
            xbps=None,
            yum='perl-Perl-Critic',
            zypper='perl-Perl-Critic',
-        ),
+        ),]


E231 missing whitespace after ','

Origin: PycodestyleBear (E231), Section: all.autopep8.

gitmate-bot · 2019-03-11T15:26:58Z

Comment on ab3e484.

No newline found between shortlog and body at HEAD commit. Please add one.

Origin: GitCommitBear, Section: all.commit.

gitmate-bot · 2019-03-14T13:10:09Z

bears/perl/PerlCriticBear.py

@@ -24,15 +28,18 @@ class PerlCriticBear:

    LANGUAGES = {'Perl'}
    REQUIREMENTS = {
-        DistributionRequirement(
+        AnyOneOfRequirements(
+        [PerlRequirement(package='Critic',version='==1.126'),


The code does not comply to PEP8.

Origin: PEP8Bear, Section: all.autopep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpoa088fpl/bears/perl/PerlCriticBear.py +++ b/tmp/tmpoa088fpl/bears/perl/PerlCriticBear.py @@ -29,16 +29,16 @@ LANGUAGES = {'Perl'} REQUIREMENTS = { AnyOneOfRequirements( - [PerlRequirement(package='Critic',version='==1.126'), - DistributionRequirement( - apt_get='libperl-critic-perl', - brew=None, - dnf='perl-Perl-Critic', - portage='dev-perl/Perl-Critic', - xbps=None, - yum='perl-Perl-Critic', - zypper='perl-Perl-Critic', - ), ] + [PerlRequirement(package='Critic', version='==1.126'), + DistributionRequirement( + apt_get='libperl-critic-perl', + brew=None, + dnf='perl-Perl-Critic', + portage='dev-perl/Perl-Critic', + xbps=None, + yum='perl-Perl-Critic', + zypper='perl-Perl-Critic', + ), ] ) } AUTHORS = {'The coala developers'}

gitmate-bot · 2019-03-14T13:10:10Z

bears/perl/PerlCriticBear.py

@@ -24,15 +28,18 @@ class PerlCriticBear:

    LANGUAGES = {'Perl'}
    REQUIREMENTS = {
-        DistributionRequirement(
+        AnyOneOfRequirements(
+        [PerlRequirement(package='Critic',version='==1.126'),


E122 continuation line missing indentation or outdented

Origin: PycodestyleBear (E122), Section: all.autopep8.

gitmate-bot · 2019-03-14T13:10:11Z

Comment on e0f4f53.

No newline found between shortlog and body at HEAD commit. Please add one.

Origin: GitCommitBear, Section: all.commit.

gitmate-bot · 2019-03-14T13:10:11Z

bears/perl/PerlCriticBear.py

@@ -24,15 +28,18 @@ class PerlCriticBear:

    LANGUAGES = {'Perl'}
    REQUIREMENTS = {
-        DistributionRequirement(
+        AnyOneOfRequirements(
+        [PerlRequirement(package='Critic',version='==1.126'),


E231 missing whitespace after ','

Origin: PycodestyleBear (E231), Section: all.autopep8.

This enhances generate_bear_requirements.py to support perl bears and generate Makefile.PL using jinja2 template. closes #2483

gitmate-bot · 2019-03-14T13:28:57Z

bears/perl/PerlCriticBear.py

+                xbps=None,
+                yum='perl-Perl-Critic',
+                zypper='perl-Perl-Critic',
+                ), 


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: all.python.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpeyw4fo2e/bears/perl/PerlCriticBear.py +++ b/tmp/tmpeyw4fo2e/bears/perl/PerlCriticBear.py @@ -38,7 +38,7 @@ xbps=None, yum='perl-Perl-Critic', zypper='perl-Perl-Critic', - ), + ), ], ), }

I think the best way to prevent any such errors are using vs code editor

gitmate-bot · 2019-03-14T13:28:58Z

bears/perl/PerlCriticBear.py

-            yum='perl-Perl-Critic',
-            zypper='perl-Perl-Critic',
+        AnyOneOfRequirements(
+            [PerlRequirement(package='Critic',version='==1.126'),


The code does not comply to PEP8.

Origin: PEP8Bear, Section: all.autopep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpeyw4fo2e/bears/perl/PerlCriticBear.py +++ b/tmp/tmpeyw4fo2e/bears/perl/PerlCriticBear.py @@ -29,7 +29,7 @@ LANGUAGES = {'Perl'} REQUIREMENTS = { AnyOneOfRequirements( - [PerlRequirement(package='Critic',version='==1.126'), + [PerlRequirement(package='Critic', version='==1.126'), DistributionRequirement( apt_get='libperl-critic-perl', brew=None,

gitmate-bot · 2019-03-14T13:28:59Z

bears/perl/PerlCriticBear.py

+                xbps=None,
+                yum='perl-Perl-Critic',
+                zypper='perl-Perl-Critic',
+                ), 


The code does not comply to PEP8.

Origin: PEP8Bear, Section: all.autopep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpeyw4fo2e/bears/perl/PerlCriticBear.py +++ b/tmp/tmpeyw4fo2e/bears/perl/PerlCriticBear.py @@ -38,8 +38,8 @@ xbps=None, yum='perl-Perl-Critic', zypper='perl-Perl-Critic', - ), - ], + ), + ], ), } AUTHORS = {'The coala developers'}

gitmate-bot · 2019-03-14T13:29:01Z

bears/perl/PerlCriticBear.py

-            yum='perl-Perl-Critic',
-            zypper='perl-Perl-Critic',
+        AnyOneOfRequirements(
+            [PerlRequirement(package='Critic',version='==1.126'),


E231 missing whitespace after ','

Origin: PycodestyleBear (E231), Section: all.autopep8.

gitmate-bot · 2019-03-14T13:29:02Z

bears/perl/PerlCriticBear.py

+                xbps=None,
+                yum='perl-Perl-Critic',
+                zypper='perl-Perl-Critic',
+                ), 


W291 trailing whitespace

Origin: PycodestyleBear (W291), Section: all.autopep8.

gitmate-bot · 2019-03-14T13:29:07Z

bears/perl/PerlCriticBear.py

+                yum='perl-Perl-Critic',
+                zypper='perl-Perl-Critic',
+                ), 
+            ],


E124 closing bracket does not match visual indentation

Origin: PycodestyleBear (E124), Section: all.autopep8.

gitmate-bot · 2019-03-14T13:29:12Z

Comment on e6d59b0.

No newline found between shortlog and body at HEAD commit. Please add one.

Origin: GitCommitBear, Section: all.commit.

AkshJain99 · 2019-03-14T13:43:08Z

@Ishaan29 you should run coala before pushing to prevent gitmate from throwing these errors

AkshJain99 · 2019-03-14T13:44:12Z

Makefile.PL

+    NAME              => 'Coala::Bears',
+    VERSION           => '0.10',
+    PREREQ_PM         => {Perl::Critic => 1.126},
+);


add blank at the end of code to prevent travis failing

AkshJain99 · 2019-03-14T13:45:18Z

bears/perl/PerlCriticBear.py

+                xbps=None,
+                yum='perl-Perl-Critic',
+                zypper='perl-Perl-Critic',
+                ), 


I think the best way to prevent any such errors are using vs code editor

KVGarg

@Ishaan29 All checks are getting failed. Try to make them green by making suggested changes by the gitmate-bot.

KVGarg · 2019-04-07T10:40:02Z

@Ishaan29 Why you closed this PR? Don't close PR un-necessarily. Suggesting you, to try to solve the issue in this PR only instead of creating another PR!

Ishaan29 · 2019-04-07T10:43:43Z

@KVGarg sorry , but have lost the track of this pr after changing my laptop(environment changed). I was unable to commit on this pr.

KVGarg · 2019-04-07T11:46:43Z

OhK 👍 Then in that nothing could be done 😄

gitmate-bot added process/pending review size/XS difficulty/low importance/low labels Mar 11, 2019

gitmate-bot assigned Ishaan29 Mar 11, 2019

gitmate-bot reviewed Mar 11, 2019

View reviewed changes

gitmate-bot reviewed Mar 14, 2019

View reviewed changes

generate_bear_requirements.py: Add Perl Metadata

e6d59b0

This enhances generate_bear_requirements.py to support perl bears and generate Makefile.PL using jinja2 template. closes #2483

gitmate-bot reviewed Mar 14, 2019

View reviewed changes

AkshJain99 reviewed Mar 14, 2019

View reviewed changes

KVGarg suggested changes Mar 18, 2019

View reviewed changes

Ishaan29 closed this Apr 7, 2019

jayvdb mentioned this pull request May 1, 2019

generate_bear_requirements.py: Add Perl Meta #2896

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

generate_bear_requirements.py: Add Perl Metadata #2888

generate_bear_requirements.py: Add Perl Metadata #2888

Ishaan29 commented Mar 11, 2019

gitmate-bot Mar 11, 2019

gitmate-bot Mar 11, 2019

gitmate-bot Mar 11, 2019

gitmate-bot Mar 11, 2019

gitmate-bot Mar 11, 2019

gitmate-bot commented Mar 11, 2019

gitmate-bot Mar 14, 2019

gitmate-bot Mar 14, 2019

gitmate-bot commented Mar 14, 2019

gitmate-bot Mar 14, 2019

gitmate-bot Mar 14, 2019

AkshJain99 Mar 14, 2019

gitmate-bot Mar 14, 2019

gitmate-bot Mar 14, 2019

gitmate-bot Mar 14, 2019

gitmate-bot Mar 14, 2019

gitmate-bot Mar 14, 2019

gitmate-bot commented Mar 14, 2019

AkshJain99 commented Mar 14, 2019

AkshJain99 Mar 14, 2019

Ishaan29 Mar 17, 2019

AkshJain99 Mar 14, 2019

KVGarg left a comment

KVGarg commented Apr 7, 2019

Ishaan29 commented Apr 7, 2019

KVGarg commented Apr 7, 2019

generate_bear_requirements.py: Add Perl Metadata #2888

generate_bear_requirements.py: Add Perl Metadata #2888

Conversation

Ishaan29 commented Mar 11, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gitmate-bot commented Mar 11, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gitmate-bot commented Mar 14, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gitmate-bot commented Mar 14, 2019

AkshJain99 commented Mar 14, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KVGarg left a comment

Choose a reason for hiding this comment

KVGarg commented Apr 7, 2019

Ishaan29 commented Apr 7, 2019

KVGarg commented Apr 7, 2019