generate_bear_requirements.py: Add Perl Meta #2896
Conversation
This enhances generate_bear_requirements.py to support perl bears and generate Makefile.PL using jinja2 template. closes coala#2483
|
Comment on 7fcd7f5. No newline found between shortlog and body at HEAD commit. Please add one. Origin: GitCommitBear, Section: |
|
@Ishaan29 There should be a blank line between |
| @@ -1,6 +1,10 @@ | |||
| from coalib.bearlib.abstractions.Linter import linter | |||
| from dependency_management.requirements.DistributionRequirement import ( | |||
| DistributionRequirement) | |||
| from dependency_management.requirements.AnyOneOfRequirements import ( | |||
| AnyOneOfRequirements) | |||
| from dependency_managment.requirements.PerlRequirement import ( | |||
There was a problem hiding this comment.
Is this dependency manager available in the coala package_manager?
There was a problem hiding this comment.
No it is not available, Thank you for pointing me in the right direction ... I will create PerlRequirement file.
There was a problem hiding this comment.
BTW the issue is not about creating a dependency. This issue is to create just Perl meta.
NM.
There was a problem hiding this comment.
I don't think there is a need to add PerlRequirement as CpanRequirement is already present..
There was a problem hiding this comment.
If CpanRequirement is the requirement here, then work with that. Adding PerlRequirement here without having it in package_manager will break it
There was a problem hiding this comment.
Will you be fixing this @Ishaan29 ?
|
Continuation of #2888 |
| WriteMakefile( | ||
| NAME => 'Coala::Bears', | ||
| VERSION => '0.10', | ||
| PREREQ_PM => {Perl::Critic => 1.126}, |
There was a problem hiding this comment.
this isnt a template if it has literal values in it.
This enhances generate_bear_requirements.py to support
perl bears and generate Makefile.PL using jinja2
template.
closes #2483