EMTF new LCT coordinate conversion LUTs #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @abrinke1 for branch master. @cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks. external issue cms-sw/cmsdist#4355 |
|
assign l1 |
|
Pull request #16 was updated. external issue cms-sw/cmsdist#4355 |
|
+1 |
|
@mrodozov , can you please prepare a cmsdist PR for this? |
|
+externals |
cmsbuild
added
externals-approved
fully-signed
and removed
externals-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. |
mrodozov
added a commit
to cms-sw/cmsdist
that referenced
this pull request
Sep 25, 2018
Testing changes from cms-data/L1Trigger-L1TMuon#16
smuzaffar
added a commit
to cms-sw/cmsdist
that referenced
this pull request
Sep 27, 2018
backport of #4365 Testing changes from cms-data/L1Trigger-L1TMuon#16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As detailed here [1], the phi coordinates computed in EMTF via the Primitive Conversion Look-Up Tables ("PC LUTs") are significantly displaced from the true coordinates, due to detector mis-alignment effects. EMTF will be loading new PC LUTs reflecting the real CMS geometry, and thus new LUTs and modifications to the emulator are needed to preserve data-emulator agreement.
The emulator changes are being PR-ed separately here: cms-sw/cmssw#24617
This update is urgently needed for the DQM.
Best regards,
Andrew for the EMTF team
[1] https://indico.cern.ch/event/758694/contributions/3146645/subcontributions/263903/attachments/1719883/2776101/2018_09_20_EMTF_alignment.pdf