EMTF new LCT coordinate conversion LUTs

[abrinke1]

As detailed here [1], the phi coordinates computed in EMTF via the Primitive Conversion Look-Up Tables ("PC LUTs") are significantly displaced from the true coordinates, due to detector mis-alignment effects. EMTF will be loading new PC LUTs reflecting the real CMS geometry, and thus new LUTs and modifications to the emulator are needed to preserve data-emulator agreement.

The new LUTs have been PR-ed separately here: cms-l1t-offline/L1Trigger-L1TMuon#9

This is a "forward port" of a PR to 10_2_X which was made a week ago, since the Online DQM is built on 10_2_5: #24617 This PR is already running at P5 and shows good data-emulator agreement.

Best regards,
Andrew and @jiafulow for the EMTF team

[1] https://indico.cern.ch/event/758694/contributions/3146645/subcontributions/263903/attachments/1719883/2776101/2018_09_20_EMTF_alignment.pdf

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24766/6709

[cmsbuild]

A new Pull Request was created by @abrinke1 for master.

It involves the following packages:

L1Trigger/L1TMuonEndCap

@nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[thomreis]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30810/console Started: 2018/10/01 11:51

[cmsbuild]

+1
Tested at: 38d69f1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24766/30810/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24766/30810/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3162800
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3162602
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[thomreis]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@abrinke1 @rekovic this PR does not seem to technically depend on cms-l1t-offline/L1Trigger-L1TMuon#9 , but are they both simultaneously needed?

[abrinke1]

Hi @fabiocos ,
I'm not actually sure if this PR to cms-l1t-offline needs to go in at all now. These files have been integrated into the master L1Trigger/L1TMuon/data directory:
cms-data/L1Trigger-L1TMuon#16
So I guess it depends on when @rekovic updates the cms-l1t-offline branch to the master branch. In any case, since this PR is to cms-sw:master, it has no dependence on cms-l1t-offline/L1Trigger-L1TMuon#9
Cheers,
Andrew

[fabiocos]

+1