Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): fix package output directory issues #287

Closed
wants to merge 2 commits into from
Closed

fix(build): fix package output directory issues #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5009b21
fix(build): add --outDir build to vite to meet the config
andypf Sep 2, 2024
182b461
fix(build): create a new changeset for communicator, oauth and k8scl…
andypf Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/fresh-poems-wash.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@cloudoperators/juno-communicator": patch
"@cloudoperators/juno-k8s-client": patch
"@cloudoperators/juno-oauth": patch
---

Fix package output directory issue by adding --outDir option to Vite CLI.
4 changes: 2 additions & 2 deletions packages/communicator/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
],
"type": "module",
"main": "build/index.js",
"module": "build/index.js",
"types": "build/types/index.d.ts",
"files": [
"build/**",
Expand All @@ -16,7 +17,6 @@
"repository": "https://github.com/cloudoperators/juno/tree/main/packages/communicator",
"license": "Apache-2.0",
"source": "src/index.js",
"module": "build/index.js",
"engines": {
"node": ">=20.0.0 <21.0.0",
"npm": ">=10.0.0 <11.0.0"
Expand All @@ -26,7 +26,7 @@
"test:watch": "vitest --watch",
"lint": "eslint ",
"dev": "vite",
"build": "vite build",
"build": "vite build --outDir build",
"serve": "vite preview",
"typecheck": "tsc --noEmit",
"clean": "rm -rf build && rm -rf node_modules && rm -rf .turbo"
Expand Down
2 changes: 1 addition & 1 deletion packages/k8s-client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"lint": "eslint",
"typecheck": "tsc --noEmit",
"dev": "vite",
"build": "vite build",
"build": "vite build --outDir build",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is already set in vite conifg why do we need it?

"serve": "vite preview",
"clean": "rm -rf build && rm -rf node_modules && rm -rf .turbo"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/oauth/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"lint": "eslint",
"typecheck": "tsc --noEmit",
"dev": "vite",
"build": "vite build",
"build": "vite build --outDir build",
"serve": "vite preview",
"clean": "rm -rf build && rm -rf node_modules && rm -rf .turbo"
}
Expand Down
Loading