Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): fix package output directory issues #287

Closed
wants to merge 2 commits into from

Conversation

andypf
Copy link
Collaborator

@andypf andypf commented Sep 2, 2024

Summary

The recent changes to the main and module entries in the package.json files for communicator, k8sClient, and oauth broke these packages. Since the build is done with Vite and the default output folder is dist, there was a discrepancy between the settings and the actual output folders.

This was fixed by adding the --outDir option to the Vite CLI.

Changes Made

  • Add --outDir option to vite CLI in
    • oauth
    • communicator
    • k8sclient

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

@andypf andypf requested a review from a team as a code owner September 2, 2024 08:10
Copy link

changeset-bot bot commented Sep 2, 2024

🦋 Changeset detected

Latest commit: 182b461

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@cloudoperators/juno-communicator Patch
@cloudoperators/juno-k8s-client Patch
@cloudoperators/juno-oauth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@andypf andypf changed the title Andypf fix packages fix(build): Fix package output directory issues Sep 2, 2024
@andypf andypf changed the title fix(build): Fix package output directory issues fix(build): fix package output directory issues Sep 2, 2024
Copy link
Contributor

@barsukov barsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets have a call on this PR, I do not think we need this changes.

@@ -16,7 +16,7 @@
"lint": "eslint",
"typecheck": "tsc --noEmit",
"dev": "vite",
"build": "vite build",
"build": "vite build --outDir build",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is already set in vite conifg why do we need it?

@andypf
Copy link
Collaborator Author

andypf commented Sep 2, 2024

Closing this PR as the changes are not needed. The outDir is already correctly set in the existing Vite configuration.

@andypf andypf closed this Sep 2, 2024
@andypf andypf deleted the andypf-fix-packages branch September 2, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants