Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add nextjs app to devcontainer #38

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

Thechi2000
Copy link
Contributor

@Thechi2000 Thechi2000 commented Aug 7, 2023

Closes #37

@Thechi2000 Thechi2000 added the build Improves the build system (devcontainer, dependencies, ...) label Aug 7, 2023
@Thechi2000 Thechi2000 self-assigned this Aug 7, 2023
@Thechi2000 Thechi2000 linked an issue Aug 7, 2023 that may be closed by this pull request
Copy link
Contributor

@codeofmochi codeofmochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🔥 LGTM see my side note below

@@ -0,0 +1,33 @@
// strapi service devcontainer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we won't need to have service-specific devcontainer configurations when #22 is merged since we won't mount vscode into a container. I'm just leaving a note so that we remove it in the future.

@Thechi2000 Thechi2000 merged commit d679240 into main Aug 8, 2023
4 checks passed
@Thechi2000 Thechi2000 deleted the 37-add-nextjs-app-to-devcontainers branch August 8, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Improves the build system (devcontainer, dependencies, ...)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add NextJS app to devcontainers
3 participants