Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add development reverse proxy #39

Merged
merged 10 commits into from
Aug 10, 2023
Merged

chore: add development reverse proxy #39

merged 10 commits into from
Aug 10, 2023

Conversation

Thechi2000
Copy link
Contributor

@Thechi2000 Thechi2000 commented Aug 8, 2023 •
edited
Loading

Closes #30

@Thechi2000 Thechi2000 added the build Improves the build system (devcontainer, dependencies, ...) label Aug 8, 2023
@Thechi2000 Thechi2000 self-assigned this Aug 8, 2023
@Thechi2000 Thechi2000 linked an issue Aug 8, 2023 that may be closed by this pull request
Reverse proxy #30
Closed
codeofmochi
codeofmochi requested changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@codeofmochi codeofmochi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work! 🍔 Have a look at my comments and let me know what you think.

BTW you can use the "close #" keyword in the PR description to link to the issue automatically 😊 E.g. in this case "close #30". See https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue.

.devcontainer/docker-compose.yaml Outdated Show resolved Hide resolved
Caddyfile-dev Outdated Show resolved Hide resolved
app/.devcontainer/Dockerfile Outdated Show resolved Hide resolved
app/.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
.devcontainer/docker-compose.yaml Outdated Show resolved Hide resolved
@codeofmochi codeofmochi changed the title 30 reverse proxy chore: add development reverse proxy Aug 8, 2023
@Thechi2000 Thechi2000 marked this pull request as ready for review August 9, 2023 11:55
codeofmochi
codeofmochi requested changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@codeofmochi codeofmochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nitpicks 🍍 otherwise LGTM

Caddyfile-dev Outdated Show resolved Hide resolved
.devcontainer/docker-compose.yaml Outdated Show resolved Hide resolved
caddy/Caddyfile.dev Outdated Show resolved Hide resolved
NoeTerrier
NoeTerrier previously approved these changes Aug 10, 2023
View reviewed changes
codeofmochi
codeofmochi previously approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@codeofmochi codeofmochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should update the value in .env.example. Otherwise LGTM 😄

strapi/.env.example Outdated Show resolved Hide resolved
@codeofmochi codeofmochi merged commit 6db75ca into main Aug 10, 2023
2 checks passed
@codeofmochi codeofmochi deleted the 30-reverse-proxy branch August 10, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeofmochi codeofmochi codeofmochi approved these changes

@NoeTerrier NoeTerrier NoeTerrier left review comments

@SidonieBouthors SidonieBouthors Awaiting requested review from SidonieBouthors

Assignees

@Thechi2000 Thechi2000

Labels
build Improves the build system (devcontainer, dependencies, ...)
Projects
CLIC website v2
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reverse proxy
3 participants
@Thechi2000 @codeofmochi @NoeTerrier