Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrated setup.py into pyproject.toml #251 #252

Merged
merged 2 commits into from
Oct 28, 2023
Merged

Conversation

whisk
Copy link
Contributor

@whisk whisk commented Oct 26, 2023

This should fix #251

Steps I made to migrate setup.py into the existing pyproject.toml:

  1. setuptools-py2cfg setup.py > tmp.cfg
  2. ini2toml tmp.cfg > tmp.toml
  3. prepend tmp.toml into the existing pyproject.toml
  4. pyprojectsort pyproject.toml
  5. validate-pyproject pyproject.toml (of course we expect "valid file" verdict here)

old setup.py left as is.

@watermelon-copilot-for-code-review

@watermelon-copilot-for-code-review

@what-the-diff
Copy link

what-the-diff bot commented Oct 26, 2023

PR Summary

  • Upgrade of build-system configuration
    The build system configuration in the pyproject.toml file was enhanced with deeper level structure, notably new build-backend and requires fields.

  • Updates to project metadata
    Updated the project metadata including details about the project's authors, what dependencies it has, its description, name, the version of Python it requires, and its own version.

  • Project License Addition
    Added a license to the project to clarify its legal protections and use cases.

  • Inclusion of Optional-Dependencies
    Added a new section that describes optional dependencies for the project, specifically for testing.

  • Addition of Project Readme
    Introduced a Readme section in the pyproject.toml file specifying the content type and text.

  • Optimization of Code Organization Tool (isort)
    Adjusted tooling for code organization (isort) for better handling of import sequences and line length.

  • Updates to setuptools
    Improved setuptools configurations to include package data and enhance compatibility with zipped (*.zip) distributions.

  • Modifications to setuptools' package finding
    Enhancements made to the way setuptools finds packages by introducing certain exclusions and considerations for namespaces.

  • Updates to Code Linter (flake8)
    Adjusted the maximum line length setting for code linter flake8 to improve code readability and maintainability.

  • Extensions to File Ignores
    The configuration for excluded files during linting and type checking was modified to include setup.py and tests/oldunit_test.py.

  • Removal of Unused Tools
    Removed unnecessary configurations for unused tools, reducing clutter and potential confusion.

  • Improvements to Static Type Checker (Pyright)
    Adjusted configurations for static type checker pyright to better manage the files it should include and exclude during its checks. This enhances the efficiency and precision of checks.

@whisk whisk mentioned this pull request Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b3916ee) 93.19% compared to head (c46f066) 93.19%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #252   +/-   ##
========================================
  Coverage    93.19%   93.19%           
========================================
  Files           33       33           
  Lines         4794     4794           
========================================
  Hits          4468     4468           
  Misses         326      326           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cleder cleder merged commit eb933c8 into cleder:develop Oct 28, 2023
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modernize packaging
2 participants