Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

274 refactor kmlpy #279

Merged
merged 23 commits into from
Nov 25, 2023
Merged

274 refactor kmlpy #279

merged 23 commits into from
Nov 25, 2023

Conversation

cleder
Copy link
Owner

@cleder cleder commented Nov 25, 2023

No description provided.

@cleder cleder linked an issue Nov 25, 2023 that may be closed by this pull request
Copy link

codecov bot commented Nov 25, 2023

Codecov Report

Attention: 263 lines in your changes are missing coverage. Please review.

Comparison is base (2b2db5a) 93.05% compared to head (ed7f69e) 91.47%.

Files Patch % Lines
fastkml/views.py 30.61% 102 Missing ⚠️
fastkml/overlays.py 67.54% 99 Missing ⚠️
fastkml/features.py 85.80% 45 Missing ⚠️
fastkml/links.py 94.20% 8 Missing ⚠️
fastkml/containers.py 95.65% 4 Missing ⚠️
fastkml/kml.py 91.11% 4 Missing ⚠️
fastkml/mixins.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #279      +/-   ##
===========================================
- Coverage    93.05%   91.47%   -1.59%     
===========================================
  Files           33       40       +7     
  Lines         4838     4574     -264     
===========================================
- Hits          4502     4184     -318     
- Misses         336      390      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Watermelon AI Summary

This Pull Request introduces a significant refactoring of the codebase for a library that handles KML files, improving code structure for better maintainability and feature handling. It cleans up type annotations, enhances parsing mechanisms, and implements new classes to better manage elements like Regions and NetworkLinks, streamlining the handling of location and time-based data.

GitHub PRs

Click here to login to Jira
Click here to login to Confluence
Click here to login to Slack
Click here to login to Notion
Click here to login to Linear
Click here to login to Asana
fastkml is an open repo and Watermelon will serve it for free.
🍉🫶

)
k2 = kml.KML()
k2.from_string(k.to_string())
k2 = kml.KML.class_from_string(k.to_string(), ns="")
assert k.to_string() == k2.to_string()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains console logs. Please review or remove them.

Copy link

what-the-diff bot commented Nov 25, 2023

PR Summary

  • Switched to a Stable Version in testing and production workflows

    • A more stable version of the Python Package Index Action is now being used when distributing packages for both testing and main releases. This brings more reliability in CI/CD processes.
  • Addition of Type Checking in Codebook

    • A hook for improved type-checking was added to the codebook, increasing the robustness of the codebase.
  • Upgraded Library Version

    • The internal version of the library was upgraded, signaling minor improvements or bug fixes.
  • Added New Files

    • Files for handling containers and links were added, introducing new features or capabilities in the software.
  • Enhanced Time Handling

    • The handling of times and timestamps was changed and optimized to a single attribute to make working with time-related properties more efficient.
  • Improved Element Handling

    • The ability to set elements has been added to the program for more versatile manipulation.
  • Simplified Altitude Mode Usage

    • The use of "altitude mode" was simplified, making it easier to use and understand.
  • Added More Test Cases

    • New test cases were included in the test suite, improving code coverage and verifying the functionality of containers, features, and overlays.
  • Updated Test Cases

    • Modified and updated existing test cases to align with any changes in the codebase or to improve their execution.
  • Renamed and Updated Test Files

    • Made changes to file names and their import statements. Renaming the 'kml_test' file to 'links_test' indicates a more narrowed testing scope now.
  • Skipped some Test Cases

    • Skipped some test cases during the testing process. Typically, these are problematic cases that have known issues or are not relevant to the current testing round.

@ghost
Copy link

ghost commented Nov 25, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@cleder cleder merged commit 816c283 into develop Nov 25, 2023
44 of 50 checks passed
@cleder cleder deleted the 274-refactor-kmlpy branch November 25, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor kml.py
2 participants