Refactor gx.Track and gx.Multitrack (Sourcery refactored) #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
PR Summary
|
sourcery-ai
bot
force-pushed
the
sourcery/refactor-gx
branch
from
1556971 to
f45ade7
Compare
sourcery-ai
bot
force-pushed
the
sourcery/refactor-gx
branch
from
f45ade7 to
2281c82
Compare
sourcery-ai
bot
force-pushed
the
sourcery/refactor-gx
branch
from
2281c82 to
69555ac
Compare
| if self._geometry is not None: | ||
| return self._geometry.geometry | ||
| return None | ||
| return self._geometry.geometry if self._geometry is not None else None |
There was a problem hiding this comment.
Function Placemark.geometry refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## refactor-gx #244 +/- ##
===============================================
+ Coverage 93.15% 93.17% +0.01%
===============================================
Files 33 33
Lines 4779 4777 -2
===============================================
- Hits 4452 4451 -1
+ Misses 327 326 -1
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request #243 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
refactor-gxbranch, then run:Help us improve this pull request!