Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor gx.Track and gx.Multitrack #243

Merged
merged 9 commits into from
Oct 15, 2023
Merged

Refactor gx.Track and gx.Multitrack #243

merged 9 commits into from
Oct 15, 2023

Conversation

cleder
Copy link
Owner

@cleder cleder commented Oct 15, 2023

fixes #242

@watermelon-copilot-for-code-review
Copy link

watermelon-copilot-for-code-review bot commented Oct 15, 2023

WatermelonAI Summary

The 9 commits in this Pull Request involve refactoring the gx.Track and gx.Multitrack features.

Commit 1 and Commit 2 establish the foundation for tracking and implementing gx.Track.

Commit 3 improves the documentation for TrackItem, making it easier for developers to understand and use.

Commit 4 removes unused types, cleaning up the codebase.

Commit 5 introduces MultiTrack, a new feature for handling multiple tracks.

Commit 6 removes outdated Geometry and GxGeometry classes.

Commit 7 fixes a test related to the tracking functionality.

Commit 8 and Commit 9 improve the code quality by using to_string instead of repr in tests, ensuring consistency and reliability.

Overall, these commits demonstrate a clean-up and enhancement of the tracking and multitrack functionalities, providing developers with improved documentation and more efficient code.

GitHub PRs

Click here to login to Jira
Click here to login to Confluence
Click here to login to Slack
Click here to login to Notion
Click here to login to Linear
Click here to login to Asana
fastkml is an open repo and Watermelon will serve it for free.
🍉🫶

@what-the-diff
Copy link

what-the-diff bot commented Oct 15, 2023

PR Summary

  • Removal of GxGeometry class
    The code has been updated to remove the GxGeometry class from our system. This simplifies the initial structure.

  • Addition of 'NAME_SPACES' dictionary
    A new dictionary named NAME_SPACES has been included, which provides an effective way to map or relate different elements in our system.

  • Update of 'register_namespaces' function
    The function register_namespaces has been modified to use a different dataset, namely DEFAULT_NAME_SPACES. This change allows for more flexible and effective data handling in the function.

  • Full update of 'fastkml/gx.py' file
    The fastkml/gx.py file has undergone a significant update which includes new imports, class definitions and functions. These enhancements specifically relate to GX features which handle directional tracks and angles, effectively improving our system's capabilities.

  • Expansion of 'Placemark' class functionality
    An update to the Placemark class in our system now allows it to handle different types of geometry. This includes new types such as gx.Track and gx.MultiTrack, broadening the class's utility and adding breadth to our geometric features.

  • Modification of test cases
    Some existing tests have been tweaked to better evaluate the code and ensure that the new changes have been implemented correctly and securely. These tests can be found in tests/data_test.py and tests/geometries/geometry_test.py.

@ghost
Copy link

ghost commented Oct 15, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (4e77361) 93.04% compared to head (c71625e) 93.15%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #243      +/-   ##
===========================================
+ Coverage    93.04%   93.15%   +0.11%     
===========================================
  Files           33       33              
  Lines         5016     4779     -237     
===========================================
- Hits          4667     4452     -215     
+ Misses         349      327      -22     
Files Coverage Δ
fastkml/__init__.py 100.00% <ø> (ø)
fastkml/config.py 100.00% <100.00%> (ø)
fastkml/geometry.py 92.53% <ø> (+0.59%) ⬆️
tests/data_test.py 100.00% <ø> (ø)
tests/geometries/geometry_test.py 100.00% <ø> (ø)
tests/gx_test.py 100.00% <100.00%> (ø)
tests/oldunit_test.py 99.76% <ø> (-0.04%) ⬇️
fastkml/kml.py 78.11% <76.92%> (+0.26%) ⬆️
fastkml/gx.py 96.32% <96.09%> (+3.30%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cleder cleder merged commit c65d97f into develop Oct 15, 2023
44 of 45 checks passed
@cleder cleder deleted the refactor-gx branch October 15, 2023 18:03
@cleder cleder mentioned this pull request Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor gx.Track and gx.Multitrack
1 participant