Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor geometry #239

Merged
merged 55 commits into from
Oct 14, 2023
Merged

Refactor geometry #239

merged 55 commits into from
Oct 14, 2023

Conversation

cleder
Copy link
Owner

@cleder cleder commented Oct 14, 2023

workerB
workerB

@watermelon-copilot-for-code-review
Copy link

watermelon-copilot-for-code-review bot commented Oct 14, 2023

WatermelonAI Summary

The 30 commits in this Pull Request mostly focus on refactoring and improving the geometry functionality. The changes include scaffolding classes, implementing the base Geometry class, adding specific classes for Point and LineString, and fixing tests for extended data. There are also updates related to type annotations, error handling, and code quality improvements like removing unused comments and adding strict parameter. The overall goal of this PR is to enhance the geometric functionality and ensure proper handling of data.

GitHub PRs

Click here to login to Jira
Click here to login to Confluence
Click here to login to Slack
Click here to login to Notion
Click here to login to Linear
Click here to login to Asana
fastkml is an open repo and Watermelon will serve it for free.
🍉🫶

@pep8speaks
Copy link

pep8speaks commented Oct 14, 2023

Hello @cleder! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1391:90: E501 line too long (115 > 89 characters)
Line 1409:90: E501 line too long (117 > 89 characters)

Comment last updated at 2023-10-14 18:22:52 UTC

Copy link
Contributor

@code-review-doctor code-review-doctor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things to consider. View full project report here.

f"tessellate={self.tessellate!r}, "
f"altitude_mode={self.altitude_mode!r} "
f"geometry={self.geometry!r}"
f")"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
f")"
")"

f-string is unnecessary here. This can just be a string. More.

@ghost
Copy link

ghost commented Oct 14, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@what-the-diff
Copy link

what-the-diff bot commented Oct 14, 2023

PR Summary

  • Expanded Python version testing matrix
    The pipeline now includes Python version 3.12 for testing compatibility
  • Updated ignored files
    Added a few more ignorable patterns and files to keep project directory clean from cache and sql files
  • Enhanced pre-commit configuration
    Several new pre-commit hooks have been added to maintain code quality standards
  • Modified manifest file
    The manifest file has been updated to include files in the schema directory during package generation
  • Added coverage details to documentation
    Developers can now find instructions for running tests with coverage in the documentation
  • Updated several python files
    Many python files dealing with geometric datas and graphics have now additional parameters for precision and verbosity for better control over output and logging.
  • Added 'Verbosity' enum
    New enum has been added to control the verbosity of logging.
  • Updated contributing doc
    Updated docs with new section covering running tests and logging coverage.
  • Renamed a test file
    The file geometry_test.py has been renamed to exceptions.py for more accurate representation of its contents
  • Updated kml file
    The fastkml file was updated with a wide range of changes, with the addition of new parameters to several classes being the most prominent of these
  • Updated toml file
    Specific error codes for two of the project's Python files have been added, thereby facilitating more granular error tracking
  • Updated requirements
    The project's pygeoif package version requirement has been updated, along with the requirement for typing_extensions
  • Updated package version
    The project package version has been updated to "1.0.alpha.5" in its setup file
  • Added more test files
    Numerous test files were added to the tests directory, featuring a range of new methods designed to expand the project's automated test coverage
  • Enhanced test method annotations
    Type hints have now been applied to all test methods in tests/times_test.py, thereby clarifying what type of arguments are expected
  • Expanded testing
    Numerous test cases have been added for date and time parsing, representing a comprehensive expansion of the project's automated testing capabilities

@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (c66e3ef) 93.02% compared to head (7901627) 93.20%.
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #239      +/-   ##
===========================================
+ Coverage    93.02%   93.20%   +0.18%     
===========================================
  Files           26       33       +7     
  Lines         4432     5080     +648     
===========================================
+ Hits          4123     4735     +612     
- Misses         309      345      +36     
Files Coverage Δ
fastkml/atom.py 100.00% <100.00%> (ø)
fastkml/enums.py 100.00% <100.00%> (ø)
fastkml/exceptions.py 100.00% <100.00%> (ø)
fastkml/gx.py 93.02% <ø> (ø)
fastkml/helpers.py 95.65% <100.00%> (ø)
fastkml/times.py 98.03% <100.00%> (+0.01%) ⬆️
fastkml/types.py 100.00% <100.00%> (ø)
fastkml/views.py 89.26% <100.00%> (+0.05%) ⬆️
tests/base_test.py 100.00% <100.00%> (ø)
tests/data_test.py 100.00% <100.00%> (ø)
... and 13 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cleder cleder merged commit f8ff74c into develop Oct 14, 2023
44 of 45 checks passed
@cleder cleder deleted the refactor-geometry branch October 14, 2023 18:27
This was referenced Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants