-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor geometry #239
Refactor geometry #239
Conversation
cleder
commented
Oct 14, 2023
add classmethod to construct a geometry from string and element #81
WatermelonAI SummaryThe 30 commits in this Pull Request mostly focus on refactoring and improving the geometry functionality. The changes include scaffolding classes, implementing the base Geometry class, adding specific classes for Point and LineString, and fixing tests for extended data. There are also updates related to type annotations, error handling, and code quality improvements like removing unused comments and adding strict parameter. The overall goal of this PR is to enhance the geometric functionality and ensure proper handling of data. GitHub PRsClick here to login to Jira |
Hello @cleder! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2023-10-14 18:22:52 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some things to consider. View full project report here.
f"tessellate={self.tessellate!r}, " | ||
f"altitude_mode={self.altitude_mode!r} " | ||
f"geometry={self.geometry!r}" | ||
f")" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f")" | |
")" |
f-string is unnecessary here. This can just be a string. More.
PR Summary
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #239 +/- ##
===========================================
+ Coverage 93.02% 93.20% +0.18%
===========================================
Files 26 33 +7
Lines 4432 5080 +648
===========================================
+ Hits 4123 4735 +612
- Misses 309 345 +36
☔ View full report in Codecov by Sentry. |