Refactor geometry (Sourcery refactored)

[sourcery-ai]

Pull Request #239 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the refactor-geometry branch, then run:

git fetch origin sourcery/refactor-geometry
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

[sourcery-ai]

Function PolyStyle.from_element refactored with the following changes:

• Lift code into else after jump in control flow (reintroduce-else)
• Replace if statement with if expression (assign-if-exp)

[sourcery-ai]

Function StyleMap.from_element refactored with the following changes:

• Merge duplicate blocks in conditional (merge-duplicate-blocks)
• Remove redundant conditional [×2] (remove-redundant-if)
• Replace multiple comparisons of same variable with in operator (merge-comparisons)

[sourcery-ai]

Function TestStdLibrary.test_base_from_element_raises refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

This removes the following comments ( why? ):

# type: ignore[attr-defined]

[watermelon-copilot-for-code-review]

Please login to Watermelon to see the results

[what-the-diff]

PR Summary

• Modification to the strtobool function in fastkml/styles.py
  The strtobool function, which is used to convert string values into boolean values, has now been modified. Instead of giving True or False, now it will provide 1 or 0, respectively. This would make it easier for other functions to interpret.

• Changes to the from_element method in fastkml/styles.py
  This method has been tweaked to add more validation checks. From now on, if the key provided to this method is None or if the text value of key is neither "highlight" nor "normal", it would raise an error message. This would prevent potential future issues by ensuring that inappropriate values are not passed to the function.

• Improvement to the test_base_from_element_raises method in tests/base_test.py
  Refinement was made to how the element variable is formatted in this method. It now uses the more efficient f-string formatting. This might enhance the readability and performance of the method.

[ghost]

👇 Click on the image for a new way to code review

Legend