Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add v9 spec based upon https://github.com/janelia-cosem/fibsem-tools/… #7

Merged
merged 2 commits into from
Feb 4, 2023

Conversation

trautmane
Copy link
Contributor

…blob/main/src/fibsem_tools/io/fibsem.py

specs/v9.tsv Outdated
702 >f4 0 MillingPIDI
706 >f4 0 MillingPIDD
800 >S30 0 MachineID
980 >f4 0 SEMSpecimenI
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the docs Mark shared, JaneliaSciComp/jeiss_fibsem_labview_control#11 (comment) , SEMSpecimenI doesn't exist, or is possibly duplicated with offset 866. They seem to encode the same thing: in your v9 files, are they the same value? If one looks like null bytes (for f4, that looks like it would be 6.41e-10) we can probably trash it. That is, assuming the header is buffered with 0s before values are written into it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spot checked v9 dats for one volume ... SEMSpecimenI at 980 is always 0.0 and SEMSpecimenICurrent at 866 varies with values like -1.2885212898254395. I'm happy to keep or trash the 980 data - I don't use either attribute.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like it's not written to (not in the screenshot sent to you either) so probably best to scrap it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just committed change that scraps it

36 >f4 2,4 Scaling
68 >u1 0 Restart
69 >u1 0 StageMove
70 >i4 0 FirstX
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know what FirstX and FirstY encode? If they're XY offsets between slices, that would be really helpful for alignment, but I'd expect them to be floats in that case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FirstX is the "X coordinate of the first pixel" and FirstY is the "Y coordinate of the first pixel".
They are integral values and are the primary reason for v9.
We asked for them to be added so that we could use them as the starting tile positions for alignment.

In case it helps, Shan emailed this screen shot of the v9 "Tracking File Headers" to Davis and me on January 27, 2022.

FIB-SEM dat file header v9

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they're integers, I guess they're in pixel units, i.e. if slice 1 was at 0,0 with pixel size (464) 12nm, then slice 2 at 1,1 would be offset by 12nm, 12nm?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes - pixel units

@clbarnes clbarnes mentioned this pull request Feb 2, 2023
…0 was always 0.0 - so likely unwritten. At @clbarnes request, removed SEMSpecimenI at 980 and renamed SEMSpecimenICurrent at 866 back to SEMSpecimenI.
@clbarnes clbarnes merged commit 8186279 into clbarnes:main Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants