Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v9 spec #6

Closed
clbarnes opened this issue Jan 26, 2023 · 3 comments
Closed

v9 spec #6

clbarnes opened this issue Jan 26, 2023 · 3 comments

Comments

@clbarnes
Copy link
Owner

clbarnes commented Jan 26, 2023

Thanks to the labview internal docs provided here JaneliaSciComp/jeiss_fibsem_labview_control#11 (comment) we have some idea of this. @trautmane also offered to take a look.

Compared to v8, there seems to be:

Additions:

dtype v9 offset v9 LabView doc
>u1 68 Restart flag
>u1 69 Stage move flag
>i4 70 X coordinate of the first pixel
>i4 74 Y coordinate of the first pixel
>S? 155 Sample ID

Subtractions:

dtype v8 offset MATLAB name
>f4 980 SEMSpecimenI

The existence of SEMSpecimenI at offset 980 is questionable, as it appears twice in the MATLAB code, even at v9: see JaneliaSciComp/jeiss_fibsem_labview_control#11 (comment)

@clbarnes
Copy link
Owner Author

clbarnes commented Feb 2, 2023

See #7

@clbarnes
Copy link
Owner Author

clbarnes commented Feb 4, 2023

@trautmane Merged! Also updated jeiss-convert if you want to give it a try. I'd recommend holding off putting it into production until we finalise the names.

Would it be possible to make a v9 file public and add the location to example_files.tsv, then add just the header section to example_metadata/? Then it'll get folded into tests.

@clbarnes
Copy link
Owner Author

clbarnes commented Feb 9, 2023

Merged

@clbarnes clbarnes closed this as completed Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant