Centralize the logic to set node name #3024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michi-covalent
added
the
release-note/misc
michi-covalent
force-pushed
the
pr/michi/node-only
branch
2 times, most recently
from
f5075a0
to
8ec47ac
Compare
Centralize the logic to set the NodeName field for event to avoid code duplication. Initialize the nodeName variable once in the node package init() function. Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
force-pushed
the
pr/michi/node-only
branch
from
8ec47ac
to
300fde9
Compare
jrfastab
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centralize the logic to set the NodeName field for events to avoid code duplication. Initialize the nodeName variable once in the node package init() function.