-
Notifications
You must be signed in to change notification settings - Fork 359
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Centralize the logic to set node name
Centralize the logic to set the NodeName fields for event to avoid code duplication. Initialize the nodeName variable once in the node package init() function. Signed-off-by: Michi Mutsuzaki <[email protected]>
- Loading branch information
1 parent
e3de28e
commit f5075a0
Showing
11 changed files
with
91 additions
and
76 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
// SPDX-License-Identifier: Apache-2.0 | ||
// Copyright Authors of Cilium | ||
|
||
package node | ||
|
||
import ( | ||
"os" | ||
"testing" | ||
|
||
"github.com/cilium/tetragon/api/v1/tetragon" | ||
"github.com/stretchr/testify/assert" | ||
) | ||
|
||
func TestGetNodeNameForExport(t *testing.T) { | ||
assert.NotEqual(t, "", GetNodeNameForExport()) // we should get the hostname here | ||
assert.NoError(t, os.Setenv("NODE_NAME", "from-node-name")) | ||
SetNodeName() | ||
assert.Equal(t, "from-node-name", GetNodeNameForExport()) | ||
assert.NoError(t, os.Setenv("HUBBLE_NODE_NAME", "from-hubble-node-name")) | ||
SetNodeName() | ||
assert.Equal(t, "from-hubble-node-name", GetNodeNameForExport()) | ||
assert.NoError(t, os.Unsetenv("NODE_NAME")) | ||
assert.NoError(t, os.Unsetenv("HUBBLE_NODE_NAME")) | ||
} | ||
|
||
func TestSetCommonFields(t *testing.T) { | ||
ev := tetragon.GetEventsResponse{} | ||
assert.Empty(t, ev.NodeName) | ||
nodeName := "my-node-name" | ||
assert.NoError(t, os.Setenv("NODE_NAME", nodeName)) | ||
SetNodeName() | ||
SetCommonFields(&ev) | ||
assert.Equal(t, nodeName, ev.GetNodeName()) | ||
assert.NoError(t, os.Unsetenv("NODE_NAME")) | ||
} |