Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/sensors: cleanup kprobe entry from table on destroy #1604

Merged
merged 3 commits into from
Oct 18, 2023
Merged

pkg/sensors: cleanup kprobe entry from table on destroy #1604

merged 3 commits into from
Oct 18, 2023

Commits on Oct 17, 2023

  1. pkg/sensors: cleanup kprobe entry from table on destroy 

    [upstream commit 5b31544]

Commit 310846e introduced a cleanup of
the kprobe table entry on unload, which introduced some issues because
unload is using when disabling sensors (that might be re-enabled later).
Previous pre and post-hooks are still useful for resources management on
unload.

The kprobe table entry is added on creation (not load) and then it must
be cleaned up on deletion introducing the new sensor.Destroy() method.
'Destroy' expresses the idea that the sensor is not usable past this
point and must be recreated to be loaded.

Signed-off-by: Mahe Tardy <[email protected]>
    @mtardy
    mtardy committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    4464a42 View commit details
    Browse the repository at this point in the history

  2. pkg/sensors/tracing: add a kprobe disable/enable regression test 

    [upstream commit 19babbb]

This should make sure the regression #1489 doesn't appear
anymore: disabling/enabling broke because we cleaned up the generic
kprobe table on unloading, which should have been done only on
destroying the probe.

Signed-off-by: Mahe Tardy <[email protected]>
    @mtardy
    mtardy committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    fefc415 View commit details
    Browse the repository at this point in the history

  3. pkg/testutils: default value for option.Config.HubbleLib 

    [upstream commit 0690282]

The testutils Config.TetragonLib (or in the end ConfigDefault.TetragonLib)
was never written to the actual option.Config.HubbleLib. We noticed it
was done manually all over the place in tests so this commit adds it in
TestSensorRun that runs in TestMain.

Signed-off-by: Mahe Tardy <[email protected]>
    @mtardy
    mtardy committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    7a85c0d View commit details
    Browse the repository at this point in the history