pkg/sensors: cleanup kprobe entry from table on destroy #1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[upstream commit 5b31544] Commit 310846e introduced a cleanup of the kprobe table entry on unload, which introduced some issues because unload is using when disabling sensors (that might be re-enabled later). Previous pre and post-hooks are still useful for resources management on unload. The kprobe table entry is added on creation (not load) and then it must be cleaned up on deletion introducing the new sensor.Destroy() method. 'Destroy' expresses the idea that the sensor is not usable past this point and must be recreated to be loaded. Signed-off-by: Mahe Tardy <[email protected]>
mtardy
added
the
kind/backport
mtardy
requested review from
tixxdz and
kkourt
and removed request for
a team and
tixxdz
[upstream commit 19babbb] This should make sure the regression #1489 doesn't appear anymore: disabling/enabling broke because we cleaned up the generic kprobe table on unloading, which should have been done only on destroying the probe. Signed-off-by: Mahe Tardy <[email protected]>
[upstream commit 0690282] The testutils Config.TetragonLib (or in the end ConfigDefault.TetragonLib) was never written to the actual option.Config.HubbleLib. We noticed it was done manually all over the place in tests so this commit adds it in TestSensorRun that runs in TestMain. Signed-off-by: Mahe Tardy <[email protected]>
mtardy
force-pushed
the
pr/mtardy/backport-hook-regression
branch
from
130e4d5
to
7a85c0d
Compare
kkourt
approved these changes
Oct 18, 2023
mtardy
added
the
release-note/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport for #1562
[upstream commit 5b31544]
Commit 310846e introduced a cleanup of the kprobe table entry on unload, which introduced some issues because unload is using when disabling sensors (that might be re-enabled later). Previous pre and post-hooks are still useful for resources management on unload.
The kprobe table entry is added on creation (not load) and then it must be cleaned up on deletion introducing the new sensor.Destroy() method. 'Destroy' expresses the idea that the sensor is not usable past this point and must be recreated to be loaded.