Update french translation #976
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When i run fr.wttr.in nearly half of the weather conditions are still in english. I tried another language (es.wttr) and everything is translated in spanish as expected. Comparing translation.txt, french translation txt's structure was different from other languages so i copied spanish structure and put the old french translations in place.
flobsx
suggested changes
May 17, 2024
| 389 : Pluies orageuses modérées à fortes : Moderate or heavy rain with thunder | ||
| 392 : Chutes de neige orageuses légères et éparses : Patchy light snow with thunder | ||
| 395 : Chutes de neige orageuses modérées à fortes : Moderate or heavy snow with thunder | ||
| 114: Temps clair: Clear |
There was a problem hiding this comment.
113: Temps clair: Clear
Code 114 not used in source code, 113 is the one (looking at other translation)
| 119: Nuageux: Cloudy | ||
| 122: Couvert: Overcast | ||
| 143: Brumeux: Mist | ||
| 176: Pluies éparses possibles: Patchy rain possible |
There was a problem hiding this comment.
176: Pluies éparses à proximité: Patchy rain nearby
176: Pluies éparses possibles: Patchy rain possible
The nearby variation also exists.
| 179: Chutes de neige éparses possibles: Patchy snow possible | ||
| 182: Chutes éparses de neige fondue possibles: Patchy sleet possible | ||
| 185: Bruines givrantes éparses possibles: Patchy freezing drizzle possible | ||
| 200: Orages possibles: Thundery outbreaks possible |
There was a problem hiding this comment.
200: Orages à proximité: Thundery outbreaks in nearby
200: Orages possibles: Thundery outbreaks possible
The nearby variation also exists.
| 365: Averses de neige fondue modérées à fortes: Moderate or heavy sleet showers | ||
| 368: Averses de neige légères: Light snow showers | ||
| 371: Averses de neige modérées à fortes: Moderate or heavy snow showers | ||
| 386: Pluies orageuses légères et éparses: Patchy light rain with thunder |
There was a problem hiding this comment.
386: Pluies orageuses légères et éparses: Patchy light rain with thunder
386: Pluies orageuses légères et éparses à proximité: Patchy light rain in area with thunder
The nearby variation also exists.
| 368: Averses de neige légères: Light snow showers | ||
| 371: Averses de neige modérées à fortes: Moderate or heavy snow showers | ||
| 386: Pluies orageuses légères et éparses: Patchy light rain with thunder | ||
| 389: Pluies orageuses modérées à fortes: Moderate or heavy rain with thunder |
There was a problem hiding this comment.
389: Pluies orageuses modérées à fortes à proximité: Moderate or heavy rain in area with thunder
389: Pluies orageuses modérées à fortes: Moderate or heavy rain with thunder
The nearby variation also exists.
| 386: Pluies orageuses légères et éparses: Patchy light rain with thunder | ||
| 389: Pluies orageuses modérées à fortes: Moderate or heavy rain with thunder | ||
| 392: Chutes de neige orageuses légères et éparses: Patchy light snow with thunder | ||
| 395: Chutes de neige orageuses modérées à fortes: Moderate or heavy snow with thunder |
There was a problem hiding this comment.
395: Chutes de neige orageuses modérées à fortes à proximité: Moderate or heavy snow in area with thunder
395: Chutes de neige orageuses modérées à fortes: Moderate or heavy snow with thunder
The nearby variation also exists.
|
I believe there might be other issues causing a similar experience for more languages, it seems e.g. for > curl -s "https://nn.wttr.in/trondheim?format=j1" | jq '.current_condition[0].weatherCode'
"302"Translation for 302 do exist for > curl -s "https://nb.wttr.in/trondheim?format=j1" | jq '.current_condition[0].lang_nb[0].value'
"Rain shower" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When i run
fr.wttr.innearly half of the weather conditions are still in english.See attached file : JSON French.json
I tried another language
es.wttr.inand everything is translated in spanish as expected.See attached file : JSON Spanish.json
Comparing translation.txt, french translation txt's structure was different from spanish one so i copied spanish structure and put the old french translations in place.