Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Update to Rust 1.84. #3459

Merged
merged 2 commits into from
Jan 9, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rust/blockstore/src/arrow/ordered_blockfile_writer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ impl ArrowOrderedBlockfileWriter {
Ok(inner)
}

pub(crate) async fn set<'a, K: ArrowWriteableKey, V: ArrowWriteableValue>(
pub(crate) async fn set<K: ArrowWriteableKey, V: ArrowWriteableValue>(
&self,
prefix: &str,
key: K,
Expand Down
4 changes: 4 additions & 0 deletions rust/garbage_collector/src/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ use figment::providers::{Env, Format, Yaml};
const DEFAULT_CONFIG_PATH: &str = "./garbage_collector_config.yaml";

#[derive(Debug, serde::Deserialize)]
// TODO(rohitcpbot): Remove this dead code annotation.
#[allow(dead_code)]
pub(super) struct GarbageCollectorConfig {
pub(super) service_name: String,
pub(super) otel_endpoint: String,
Expand All @@ -14,6 +16,8 @@ pub(super) struct GarbageCollectorConfig {
}

#[derive(Debug, serde::Deserialize)]
// TODO(rohitcpbot): Remove this dead code annotation.
#[allow(dead_code)]
pub(super) struct SysdbConnectionConfig {
host: String,
port: u32,
Expand Down
2 changes: 1 addition & 1 deletion rust/worker/src/execution/operators/limit.rs
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ struct SeekScanner<'me> {
mask: &'me RoaringBitmap,
}

impl<'me> SeekScanner<'me> {
impl SeekScanner<'_> {
// Find the rank of the target offset id in the imaginary segment
//
// The rank of a target is the number of elements strictly less than it
Expand Down
2 changes: 1 addition & 1 deletion rust/worker/src/segment/types.rs
Original file line number Diff line number Diff line change
Expand Up @@ -867,7 +867,7 @@ pub enum ChromaSegmentWriter<'bf> {
DistributedHNSWSegment(Box<DistributedHNSWSegmentWriter>),
}

impl<'a> ChromaSegmentWriter<'a> {
impl ChromaSegmentWriter<'_> {
pub fn get_id(&self) -> SegmentUuid {
match self {
ChromaSegmentWriter::RecordSegment(writer) => writer.id,
Expand Down
Loading