Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE] Update to Rust 1.84. #3459

Merged
merged 2 commits into from
Jan 9, 2025
Merged

[CHORE] Update to Rust 1.84. #3459

merged 2 commits into from
Jan 9, 2025

Conversation

rescrv
Copy link
Contributor

@rescrv rescrv commented Jan 9, 2025

Just some clippy lint.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@rohitcpbot rohitcpbot self-requested a review January 9, 2025 21:59
rohitcpbot
rohitcpbot approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@rohitcpbot rohitcpbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rescrv rescrv merged commit 49b13f1 into main Jan 9, 2025
79 checks passed
@rescrv rescrv deleted the rescrv/did-rust-break-under-us branch January 9, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitcpbot rohitcpbot rohitcpbot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rescrv @rohitcpbot