[BUG] Use len_with_deleted instead of len #3431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
chroma-droid
pushed a commit
that referenced
this pull request
Jan 8, 2025
## Description of changes This is a follow-up from #3424 - where I had added code to fix the bug in compaction but then forgot to replace the method at the actual callsite with the new method 🤦🏼 . This updates the problem code to use `len_with_deleted` instead of just `len` so that the resize actually gets triggered. Some additional context: we decided not to change the behavior of the existing `len` method in case other callers were depending on existing behavior. In other words, we didn't want to introduce accidentally introduce bugs that were relying on the "buggy" code.
chroma-droid
pushed a commit
that referenced
this pull request
Jan 8, 2025
## Description of changes This is a follow-up from #3424 - where I had added code to fix the bug in compaction but then forgot to replace the method at the actual callsite with the new method 🤦🏼 . This updates the problem code to use `len_with_deleted` instead of just `len` so that the resize actually gets triggered. Some additional context: we decided not to change the behavior of the existing `len` method in case other callers were depending on existing behavior. In other words, we didn't want to introduce accidentally introduce bugs that were relying on the "buggy" code.
eculver
added a commit
that referenced
this pull request
Jan 8, 2025
This PR cherry-picks the commit 75aeb81 onto release/2025-01-03. If there are unresolved conflicts, please resolve them manually. Co-authored-by: Evan Culver <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This is a follow-up from #3424 - where I had added code to fix the bug in compaction but then forgot to replace the method at the actual callsite with the new method 🤦🏼 .
This updates the problem code to use
len_with_deletedinstead of justlenso that the resize actually gets triggered.Some additional context: we decided not to change the behavior of the existing
lenmethod in case other callers were depending on existing behavior. In other words, we didn't want to introduce accidentally introduce bugs that were relying on the "buggy" code.