Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GET request to nsqlookupd times out #41

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

GET request to nsqlookupd times out #41

wants to merge 1 commit into from

Commits on Mar 16, 2016

  1. GET request to nsqlookupd doesn't hang forever 

    Krakow makes a request to lookupd to get the list of nsqd nodes. If for any
reason lookupd takes a long time to respond Krakow will wait forever.

Even worst, it seems that this requests block the flow of NSQ messages from
the already discovered nsqd nodes.

Luckily http supports timeouts: https://github.com/httprb/http/wiki/Timeouts

Possible fix to chrisroberts#31 (comment)
    @xoen
    xoen committed Mar 16, 2016
    Configuration menu
    Copy the full SHA
    d656527 View commit details
    Browse the repository at this point in the history