GET request to nsqlookupd times out #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krakow makes a request to lookupd to get the list of nsqd nodes. If for any reason lookupd takes a long time to respond Krakow will wait forever. Even worst, it seems that this requests block the flow of NSQ messages from the already discovered nsqd nodes. Luckily http supports timeouts: https://github.com/httprb/http/wiki/Timeouts Possible fix to chrisroberts#31 (comment)
|
Any news on this @chrisroberts :)? PS: This solves the problem when nsqlookupd hangs out (discovery is done via an HTTP request), but it does not solve the problem when nsqd nodes hang out (as far I can tell it's using TCP connections there). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Krakow makes a request to lookupd to get the list of nsqd nodes. If for any
reason lookupd takes a long time to respond Krakow will wait forever.
Even worst, it seems that this requests block the flow of NSQ messages from
the already discovered nsqd nodes.
Possible fix to #31 Krakow stops processing messages