-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CJK support, Copy and Paste support #97
base: master
Are you sure you want to change the base?
Conversation
To test with tty.js, following patch need to be applied.
|
Certain keyboard layouts and operating systems rely on alt+key combinations to type characters. This should add support for these special characterss.
+1 |
Hi yoshiokatsuneo,
|
@e1ee1e11 I'm sorry but I cannot reproduce the issue. I think it is nice to have a capture image... |
I'm read and test his code, it's works for me and the code seems fine. |
Use yoshiokatsuneo's code, fix this bug. His idea is append a textarea and bind all click event on it. That works for us #59 chjj/term.js#97
chjj#97 (rancher/rancher##2181)
@codehz This can't be happen... Please give a short code to reconstruct it. I am very curious about it |
@liuzheng712 你用的是什么版本的term.js,我用的是Rancher的,还有我用的是前面提到的TTY.js修改方式对tty.js打了补丁 Which term.js version are you using? I am using rancher/term.js . And I use the patch by yoshiokatsuneo for tty.js. |
@codehz I'm only using yoshiokatsuneo's verstion, if it possible , Please create a git repository. |
@liuzheng712 I use tty.js, I will create a repo tomorrow(GMT+8)... |
@codehz ok, BTW I'm Chinese~ I know you are Chinese too ... I'm in Shanghai~ |
@liuzheng712 I have create a repo for this. latest commit is codehz/tty.js@d45942b |
@codehz I'm use OS X Yosemite 10.10.5, Chrome 49.0.2623.87 (64-bit) |
@liuzheng712 I'm use win 10, Chrome 49, (tty.js run on Linux vm) it may be the reason. |
@liuzheng712 Can you try to use some program to get text direct from stdin, I mean do not use readline library, just use scanf function or std::cin. #include <iostream>
int main() {
char test[32];
std::cin >> test;
std::cout << test << std::endl;
return 0;
} I do not believe this issue depends on OS. |
@yoshiokatsuneo your cjk branch code works perfect, thanks! 👍 |
…eeded for having paste option in firefox
… introduce new bugs and have some wierd behaviour together with GL. Other changes are related to native scroll and we don't need that right now
…his is needed for having paste option in firefox" This reverts commit 8036480.
No description provided.