forked from chjj/term.js
-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Certain keyboard layouts and operating systems rely on alt+key combinations to type characters. This should add support for these special characterss.
- Loading branch information
1 parent
85e8373
commit 2cc287f
Showing
1 changed file
with
27 additions
and
34 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2cc287f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I guess you are tying to support non English language. I also tried to handle non-English characters(Japanese for me), for both input and output with copy and paste.
chjj#97
2cc287f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yoshiokatsuneo Yes, I have been trying to support non English characters. I had a chance to review your work and I like what you have done. May I merge your changes into my fork?
I use this fork for a personal project of mine. The people who use my project would greatly appreciate the work that you have done.
2cc287f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeremyramin Yes, of course, it is quite nice if you can review it !
2cc287f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me, I could confirm that I can input Japanese by replacing term.js and adding Terminal.prototype.stopScrolling() to it.
2cc287f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yoshiokatsuneo Excellent! I will merge your changes and release a new update to Terminal-Plus. Thank you for your work.