Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] replace perf.json total_cycles value when instrument found #936

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Avimitin
Copy link
Contributor

@Avimitin Avimitin commented Jan 9, 2025

Signed-off-by: Avimitin [email protected]

@Avimitin Avimitin mentioned this pull request Jan 9, 2025
4 tasks
@Avimitin
Copy link
Contributor Author

Avimitin commented Jan 9, 2025

This PR is intended to correctly calculate the actual cycle count for the rvv-bench project. However, each test in rvv-bench will start Scalar, Auto Vectorization and RVV tests, it is tedious to insert program instrument to all tests. Besides, adding a patch to benchmark tests that cannot be upstreamed is not what we expected.

So this PR can be merged after CI pass, but currently we will not use this feature for our test cases.

@FanShupei
Copy link
Contributor

Personally I suggest add data instead of replacing it. The file perf.json actually record various metadata for the simulation of DPI side. If the name of fields in perf.json is ambiguous, free free to change it at https://github.com/chipsalliance/t1/blob/65ae0fa4317ebea48f2e952cf030de3898d3186a/difftest/dpi_common/src/util.rs#L3C1-L22C2

Maybe we change orignal total_cycle to sim_total_cycle, add the new cycle as perf_cycle?

@Avimitin Avimitin force-pushed the instrument branch 2 times, most recently from 0890996 to 8a8a242 Compare January 11, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants