[nix] Add vcs sim profile flow #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avimitin
reviewed
Dec 8, 2024
| emuDriverArgs="''${emuDriverArgsArray[@]}" | ||
| emuDriver="${emulator}/bin/${emulator.mainProgram}" | ||
| emuDriver="${emuDriver}" | ||
| emuDriverArgs="${lib.escapeShellArgs emuDriverArgs}" |
There was a problem hiding this comment.
Here the emuDriverArgs is escaped into bash string "'argA' 'argB' 'argC'", this might cause some unexpected behavior in future modification. But just left it here if it is ok for now.
|
please rebase and squash |
FanShupei
force-pushed
the
vcs-profile
branch
from
5ba3341 to
17a61c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profile vcs simulation time
Since we do not want to cache prof results anyway, we couldn't use 'nix build'. The flow is a bit distorted.
Usage:
enableProfile = truein 'sv-to-vcs-simulator.nix'