-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cosmic Refactor #751
Merged
Cosmic Refactor #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to new dpi framework, and use $plusagr for cmd parsing.
sequencer
reviewed
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally support plusargs!
Comment on lines
-20
to
+21
"--elf-file" | ||
"${testCase}/bin/${testCase.pname}.elf" | ||
${lib.optionalString emulator.enable-trace "--wave-path"} | ||
${lib.optionalString emulator.enable-trace "${testCase.pname}.fsdb"} | ||
"+t1_elf_file=${testCase}/bin/${testCase.pname}.elf" | ||
${lib.optionalString emulator.enable-trace "+t1_wave_path=${testCase.pname}.fsdb"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable Changes:
move t1/t1rocket DPI libs to
difftest/{dpi_t1 / dpi_t1_rocket}
, refactor common DPI code todpi_common
DPI libs now use plusargs for command line parsing, instead of clap-rs
DPI libs now use
RUST_LOG
environment variable to control log level. See RUST_LOGVerilator build is temporally broken. Rust-based Verilator shims are removed. We will develop new Verilator flow utilizing
libdpi_XXX.a
later.