Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmic Refactor #751

Merged
merged 7 commits into from
Aug 29, 2024
Merged

Cosmic Refactor #751

merged 7 commits into from
Aug 29, 2024

Conversation

FanShupei
Copy link
Contributor

@FanShupei FanShupei commented Aug 27, 2024

Notable Changes:

  • move t1/t1rocket DPI libs to difftest/{dpi_t1 / dpi_t1_rocket}, refactor common DPI code to dpi_common

  • DPI libs now use plusargs for command line parsing, instead of clap-rs

  • DPI libs now use RUST_LOG environment variable to control log level. See RUST_LOG

  • Verilator build is temporally broken. Rust-based Verilator shims are removed. We will develop new Verilator flow utilizing libdpi_XXX.a later.

Copy link
Member

@sequencer sequencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally support plusargs!

difftest/dpi_t1rocket/Cargo.toml Show resolved Hide resolved
nix/t1/vcs.nix Show resolved Hide resolved
Comment on lines -20 to +21
"--elf-file"
"${testCase}/bin/${testCase.pname}.elf"
${lib.optionalString emulator.enable-trace "--wave-path"}
${lib.optionalString emulator.enable-trace "${testCase.pname}.fsdb"}
"+t1_elf_file=${testCase}/bin/${testCase.pname}.elf"
${lib.optionalString emulator.enable-trace "+t1_wave_path=${testCase.pname}.fsdb"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@sequencer sequencer merged commit 17f2b23 into master Aug 29, 2024
160 checks passed
@sequencer sequencer deleted the refactor branch August 29, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants