Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Zvbb #671

Merged
merged 5 commits into from
Aug 6, 2024
Merged

support Zvbb #671

merged 5 commits into from
Aug 6, 2024

Conversation

Lucas-Wye
Copy link
Contributor

No description provided.

@Lucas-Wye Lucas-Wye marked this pull request as draft July 11, 2024 15:20
@Avimitin Avimitin marked this pull request as ready for review July 26, 2024 05:32
@Lucas-Wye Lucas-Wye force-pushed the supp-zvbb branch 3 times, most recently from 0f5a8da to 1c19fe4 Compare July 27, 2024 11:28
@Lucas-Wye Lucas-Wye force-pushed the supp-zvbb branch 3 times, most recently from 4785586 to 4cf1bce Compare August 6, 2024 02:04
Copy link
Member

@sequencer sequencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see CI clean:)
please work on these nitpicks, and we can get it merged.

package org.chipsalliance.t1.rtl

import chisel3.experimental.hierarchy.instantiable
import chisel3.{UInt, _}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import chisel3.{UInt, _}
import chisel3._

import chisel3.{UInt, _}
import chisel3.experimental.{SerializableModule, SerializableModuleParameter}
import chisel3.util._
import hardfloat._
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why hardfloat.

Comment on lines 9 to 17
object zvbbUop0 extends ZvbbUOPType
object zvbbUop1 extends ZvbbUOPType
object zvbbUop2 extends ZvbbUOPType
object zvbbUop3 extends ZvbbUOPType
object zvbbUop4 extends ZvbbUOPType
object zvbbUop5 extends ZvbbUOPType
object zvbbUop6 extends ZvbbUOPType
object zvbbUop7 extends ZvbbUOPType
object zvbbUop8 extends ZvbbUOPType
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, please, please...

@Lucas-Wye Lucas-Wye force-pushed the supp-zvbb branch 2 times, most recently from fefdec7 to 053f298 Compare August 6, 2024 07:07
@sequencer
Copy link
Member

Ok, first milestone to Zvk

@sequencer sequencer merged commit 766c5e3 into master Aug 6, 2024
84 checks passed
@sequencer sequencer deleted the supp-zvbb branch August 6, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants