Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nix] fix up omreader missing in nix #619

Merged
merged 1 commit into from
Jun 3, 2024
Merged

[nix] fix up omreader missing in nix #619

merged 1 commit into from
Jun 3, 2024

Conversation

sequencer
Copy link
Member

No description provided.

@sequencer sequencer requested a review from SpriteOvO June 3, 2024 09:52
SpriteOvO
SpriteOvO approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@SpriteOvO SpriteOvO left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was removed them because it could avoid rebuilding the whole T1 if just omreader changed. However if we revert this, we still need a way to avoid rebuilding.. It's really slow.

@sequencer sequencer merged commit d041a8d into master Jun 3, 2024
11 of 82 checks passed
@sequencer sequencer deleted the omreader-fix branch June 3, 2024 10:54
@sequencer
Copy link
Member Author

Our inhouse flow just require a monorepo of T1, I don't want to add too much code in the inhouse flow, the reason of inhouse exist is because there are some NDA under Jiuyang and different companies, as well as EDA tools, we want them to be as minimal as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpriteOvO SpriteOvO SpriteOvO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sequencer @SpriteOvO