Draft Instruction Object Model #514
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sequencer
commented
Apr 9, 2024
| /** Generate documentation for each instructions for T1. | ||
| * The documentation should contain the behavior for instruction in a specific configuration in T1. | ||
| */ | ||
| case class InstructionDocumentation(instruction: Instruction, t1Parameter: T1Parameter) { |
There was a problem hiding this comment.
This is how to start to review the decoder: adding documentation to each instructions. Describing the lifetime of each instruction in a specific type of T1.
After finish this review, a clear documentation will be a artifact.
There was a problem hiding this comment.
we may also add attributes here parameters? I'm not sure.
t1/src/decoder/T1DecodePattern.scala
Outdated
Comment on lines
90
to
179
| // Below is the Scala in-memory attributes queried from DecodeTable. | ||
| def isVector = instruction.instructionSet.name == "rv_v" | ||
| // TODO: we can even use a Enum here. | ||
| def useLaneExec: String = ??? | ||
|
|
||
|
|
There was a problem hiding this comment.
Add attribute like this.
sequencer
force-pushed
the
decoder-om
branch
2 times, most recently
from
8bce0bc to
9f0f162
Compare
|
@Lucas-Wye This will be 2 weeks work, let's finish it during next two weeks, It should be the first round of GSoC project. |
sequencer
force-pushed
the
decoder-om
branch
2 times, most recently
from
22a03b9 to
8c988e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.