-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[major] Add reference types. #75
Merged
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
84ccba7
[major] Add reference types.
dtzSiFive 43b1962
Add text clarifying RWProbe<const T> and width/reset inference.
dtzSiFive 4bcc953
touchup header depth, add text about what can be "define"d.
dtzSiFive 8aa183c
Drop probe of memory.
dtzSiFive 386df56
Touchup nested example, add missing port, set width on input.
dtzSiFive c13b460
Fixup "AddRefs" example, capitalization typo, node init syntax.
dtzSiFive 79b990d
ref statement as mandatory for now.
dtzSiFive 9f6697b
Clarify input probe refs also can't be context-dependent.
dtzSiFive dfceec7
Clarify references != probes a bit more.
dtzSiFive 35a4668
Touchup language differentiating probe-types from references generally.
dtzSiFive 3e0fd19
[NFC] (reflow)
dtzSiFive b8021d7
touchup stale language re:optional ref statement
dtzSiFive 6c516f7
[NFC] (reflow)
dtzSiFive File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes a lot of sense to me to restrict this. 👍